fix(aria-prohibited-attr): update metadata message #3206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zidious
changed the title
messageKey for prohibited attrs
Zidious
changed the title
messageKey for prohibited attrs
WilcoFiers
approved these changes
Oct 14, 2021
|
reviewed |
This was referenced Jan 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update metadata message for prohibited attributes.
Note: There are some ARIA roles whereby the name is prohibited, but the HTML element (HTML role-mapping) has no role to map to e.g.
codeandsubtherefore, it falls under incomplete, I have updated the message to make it a bit more clear. Do we want to explicitly check for HTML elements that have a corresponding ARIA role in 1.2 and fail them?Closes issue: #3205