tests: check that every check has a message for every return type and messageKey #3181
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will check that every time a checks unit test is run, it verifies that there exists a message for the return type, also taking into account how
none
checks use the opposite messages (e.g. a result oftrue
will use afail
message). It will also verify that if the check has adata.messageKey
property, that a specific message exists in the messages for that key.Doing this revealed that we should combine the
non-empty-if-present
andnon-empty-value
checks as the fail state for what it's looking for (the state of thevalue
attribute) produces a double message about the attribute:Also made sure no
pass
result had a message key it didn't use in color-contrast (which seems to have run prettier on the file so that's why all the changes)Closes issue: #3173