fix(nativeSelectValue): update selected value on change #3154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
straker
previously requested changes
Sep 10, 2021
There was a problem hiding this comment.
Awesome. That looks better. One last thing, could you add a test to https://github.com/dequelabs/axe-core/blob/develop/test/core/base/virtual-node/virtual-node.js? I know we don't have tests for the node specific props (multiple, nodeValue, value, etc.), but I think that might be a failing on our part.
The test can be as simple "node with selected property is reflected in props" or something, just so we don't delete it one day without knowing.
straker
reviewed
Sep 10, 2021
| @@ -97,6 +107,32 @@ describe('VirtualNode', function() { | |||
| }); | |||
| }); | |||
|
|
|||
| describe('props', function() { | |||
There was a problem hiding this comment.
Did you mean to add these tests? They look like copy/paste from the previous describe('attr')
There was a problem hiding this comment.
Oops! Deleted!
kevin940726
force-pushed
the
fix/select-value
branch
from
88d8ba0 to
2ce8af8
Compare
straker
approved these changes
Sep 13, 2021
|
Reviewed for security |
straker
changed the title
nativeSelectValue not picking up selection
straker
pushed a commit
that referenced
this pull request
Oct 18, 2021
* Fix nativeSelectValue not picking up selection * Use props instead * Add test for selected prop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nativeSelectValuedoesn't return the selected value after manual selection. This PR fixes that by using theselectedon<option>to get the up-to-date value.