Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: start server on integration test #2664

Merged
merged 7 commits into from
Nov 30, 2020
Merged

tests: start server on integration test #2664

merged 7 commits into from
Nov 30, 2020

Conversation

straker
Copy link
Contributor

@straker straker commented Nov 25, 2020

Closes issue: #2658

Reviewer checks

Required fields, to be filled out by PR reviewer(s)

  • Follows the commit message policy, appropriate for next version
  • Code is reviewed for security

@straker straker requested a review from a team as a code owner November 25, 2020 20:44
@straker straker changed the title tests: start server when integration test tests: start server on integration test Nov 25, 2020
Copy link
Member

@stephenmathieson stephenmathieson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we're intentionally adding a race condition, but I'm not sure how else to handle this. LGTM but we should keep an eye on this.

@straker
Copy link
Contributor Author

straker commented Nov 25, 2020

Nope, this is still timing out after 47 tests... I have no idea what is going on but I don't know how else to do this in a single command so we don't have to start the server beforehand

@stephenmathieson
Copy link
Member

If you like, we can pair on it next week. Should I set something up?

@straker
Copy link
Contributor Author

straker commented Nov 26, 2020

IT WORKS! So this is the "best" way I've found to do this but it adds a lot of npm scripts.

start-server-and-test does what we want, but it has a problem in that it can't pass command line arguments to the test command. That resulted in creating individual test scripts for each of the browsers. Unfortunately, it also has a bug in Windows that doesn't allow it to work with npm commands, so I had to create yet another set of individual test scripts so we can run the script name instead of a command.

@stephenmathieson
Copy link
Member

Well done! Glad you figured it out!

@straker straker merged commit 231eaeb into develop Nov 30, 2020
@straker straker deleted the integration-server branch November 30, 2020 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants