Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: run prettier #2659

Merged
merged 2 commits into from
Nov 24, 2020
Merged

chore: run prettier #2659

merged 2 commits into from
Nov 24, 2020

Conversation

straker
Copy link
Contributor

@straker straker commented Nov 24, 2020

Noticed this when converting our tests to karma. The package.json file does not use husky to run the prettier step so prettier hasn't been run in awhile.

I also took the opportunity to change prettier to use spaces instead of tabs (we discussed this before and found tabs to be outdated and wanted spaces instead).

Important files:

package.json

"husky": {
    "hooks": {
      "pre-commit": "lint-staged"
    }
  },

.prettierrc:

  "useTabs": false,
  "tabWidth": 2,

Reviewer checks

Required fields, to be filled out by PR reviewer(s)

  • Follows the commit message policy, appropriate for next version
  • Code is reviewed for security

@straker straker requested a review from a team as a code owner November 24, 2020 16:44
Copy link
Member

@stephenmathieson stephenmathieson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is basically impossible to review, however, since the tests pass and I trust that our automated tooling did the right thing, this LGTM.

Side note - I'm glad we're moving away from hard tabs. IMO 2-space indents make it much easier to review/read code in the GitHub UI.

@@ -1,6 +1,7 @@
{
"printWidth": 80,
"useTabs": true,
"useTabs": false,
"tabWidth": 2,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's ironic that the Prettier config is not "prettier".

@straker straker merged commit f2f1537 into develop Nov 24, 2020
@straker straker deleted the prettier branch November 24, 2020 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants