-
Notifications
You must be signed in to change notification settings - Fork 779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(heading-order): allow partial context to pass #2622
Conversation
I have tried to debug this in IE11 for hours but can't figure out what's going on. It doesn't help that it's flakey for some reason. Best I can figure is that the iframe isn't running / returning axe results to the parent and so the iframe results are completely missing from the results object. Sometimes (rarely) the iframe times out and we get an error "Axe in frame timed out," but this doesn't happen every time the iframe results aren't in the results object. A lot of the times when devtools are open the tests pass magically, or when I add console logs or debuggers. This makes me think it's a race condition, but I can't figure out where the problem is occurring in our integration It also always passes if you just run the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple minor points
These changes allow partial
heading-order
context to pass. It will also handle iframes if they are included in the context or not.Closes issue: #728
Reviewer checks
Required fields, to be filled out by PR reviewer(s)