Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(rule-matches): depreacte window-is-top-matches for is-intiator-matches #2531

Merged
merged 1 commit into from
Sep 28, 2020
Merged

feat(rule-matches): depreacte window-is-top-matches for is-intiator-matches #2531

merged 1 commit into from
Sep 28, 2020

Conversation

straker
Copy link
Contributor

@straker straker commented Sep 25, 2020 •
edited by WilcoFiers
Loading

This allows Cypress to run document-title and html-has-lang rules inside the iframe by making whichever context axe.run was called the "top-level" context (be it an iframe or the top-most window).

Closes issue: #1618

Reviewer checks

Required fields, to be filled out by PR reviewer(s)

  • Follows the commit message policy, appropriate for next version
  • Code is reviewed for security

@straker straker requested a review from a team as a code owner September 25, 2020 16:53
@straker straker merged commit db2be93 into develop Sep 28, 2020
@straker straker deleted the is-initiator-matches branch September 28, 2020 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WilcoFiers WilcoFiers WilcoFiers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@straker @WilcoFiers