Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(svg-non-empty-title): update fail message #2462

Merged
merged 1 commit into from
Aug 19, 2020
Merged

feat(svg-non-empty-title): update fail message #2462

merged 1 commit into from
Aug 19, 2020

Conversation

42tte
Copy link
Contributor

@42tte 42tte commented Aug 17, 2020 •
edited by straker
Loading

Update fail message to indicate if the title element is empty or missing

Closes issue #2452

Reviewer checks

Required fields, to be filled out by PR reviewer(s)

  • Follows the commit message policy, appropriate for next version
  • Code is reviewed for security

@42tte
feat(svg-non-empty-title): update fail message
e6fbd68 
Update fail message to indicate if the title element is empty or missing

Closes issue dequelabs#2452
@42tte 42tte requested a review from a team as a code owner August 17, 2020 12:26
@CLAassistant
Copy link

CLAassistant commented Aug 17, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

straker
straker approved these changes Aug 19, 2020
View reviewed changes
Copy link
Contributor

@straker straker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work! Thanks for the pr.

@straker straker merged commit 5b4a935 into dequelabs:develop Aug 19, 2020
straker pushed a commit that referenced this pull request Sep 8, 2020
@42tte @straker
fix(svg-non-empty-title): update fail message to indicate if the titl…
9598656 
…e element is empty or missing (#2462)

Update fail message to indicate if the title element is empty or missing

Closes issue #2452
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@straker straker straker approved these changes

Assignees

@straker straker

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@42tte @CLAassistant @straker