feat: add layout-table-matches method #2400
Conversation
There was a problem hiding this comment.
You'll need to export this function in the metadata-function-map file so it a rule can use it by name. https://github.com/dequelabs/axe-core/blob/develop/lib/core/base/metadata-function-map.js
| import { isDataTable } from '../commons/table'; | ||
| import { isFocusable } from '../commons/dom'; | ||
|
|
||
| // TODO: es-modules add tests. No way to access this on the `axe` object |
There was a problem hiding this comment.
This looks like an "ES Module" to me. I do not understand this TODO.
There was a problem hiding this comment.
The issue is that we can't import this into our tests because those don't use es modules yet. Since I can't import it, and it isn't on the global axe object, there's no way for me to access this, so I haven't added tests for it.
There was a problem hiding this comment.
I see, thanks for clarifying.
There was a problem hiding this comment.
I created a ticket for it so we don't forget #2403
TECH DEBT: There are no tests for this. Because this matches isn't used in any rule, it can't be accessed on the
axeobject. This can be solved once we have Babel enabled on our tests.Closes issue:
Reviewer checks
Required fields, to be filled out by PR reviewer(s)