fix(implicit-roles): add proper implicit role calculation #2242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WilcoFiers
previously requested changes
May 21, 2020
WilcoFiers
previously requested changes
May 29, 2020
WilcoFiers
previously requested changes
Jun 5, 2020
Co-authored-by: Wilco Fiers <[email protected]>
Co-authored-by: Wilco Fiers <[email protected]>
WilcoFiers
approved these changes
Jun 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've had quite a few bugs in our implicit role calculations being incorrect so we wanted to rewrite it to be correct. Once this is in, we can finalize the role computations by adding role conflict resolution and
role=presentationinheritance.The implicit roles were taking from https://www.w3.org/TR/html-aam-1.0/ and https://www.w3.org/TR/html-aria/.
Note: this probably could replace the
implicitproperty from the roles table, but that is used byimplicit-nodesand I didn't feel comfortable touching that yet. So we may need to make a tech debt ticket for that.Closes issue: #2236
Reviewer checks
Required fields, to be filled out by PR reviewer(s)