feat: support check evaluate functions as an id string #2162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ck evaulate functions as an id string
WilcoFiers
approved these changes
Apr 14, 2020
WilcoFiers
changed the title
WilcoFiers
changed the title
| // TODO: es-modules-rules | ||
| // import all check evaluate and after functions, and all rule matches functions | ||
|
|
||
| const metadataFunctionMap = new Map(); |
There was a problem hiding this comment.
I thought we were going to have a map for checks and a map for rules? How will we differenciate between the different types of functions here?
For example:
map.set('some-fn', (some, args) => { /* ... */ })
Is the above for a check eval, a check after or a rule matches?
There was a problem hiding this comment.
The id for each function will be unique and include the type in the name. E.g. aria-allowed-attr-matches, aria-allowed-attr-evaluate, aria-allowed-attr-after
stephenmathieson
added a commit
that referenced
this pull request
Apr 16, 2020
Had several conflicts, may be a bad merge.... 🤷 * core-utils-modules: refactor: update filenames of check evaluate and rule matches (#2160) feat(metadata-function-map): add metadata function map to support check evaulate functions as an id string (#2162) put back check skip rather than comment comment for now moar tests refactor(core/reporters): Convert to ES modules (#2154) fix(duplicate-id): list the duplicate id in message (#2163) chore: convert commons to ES Modules (#2155) refactor(Audit): Convert to ES5 class (#2157) refactor(core/utils): Convert to ES modules
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating the stub for the map that will allow checks to use a string id to access shared evaluate and after functions. Once checks have been converted to es modules we can add them all to the map and have the feature working.
Closes issue:
Reviewer checks
Required fields, to be filled out by PR reviewer(s)