feat(svg-img-alt): rule for when svg needs a title #1953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
straker
previously requested changes
Dec 19, 2019
WilcoFiers
dismissed
straker’s stale review
Sorted, please take another look
jeeyyy
approved these changes
Dec 20, 2019
straker
approved these changes
Jan 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new svg-img-alt rule checks that the
svgelements withrole=graphics-document, and any element in the SVG namespace that hasrole=imgorrole=graphics-symbolhas an accessible name, either through ARIA label, thetitleattribute or by having a non-empty childtitleelement.This rule limits the role-img-alt rule to elements in the HTML namespace to avoid overlap with the svg-img-alt rule.
Closes issue: #20
Reviewer checks
Required fields, to be filled out by PR reviewer(s)