Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(accessible-text-virtual): sanitize attributes on start node #1694

Merged
merged 2 commits into from
Jul 12, 2019
Merged

fix(accessible-text-virtual): sanitize attributes on start node #1694

merged 2 commits into from
Jul 12, 2019

Conversation

straker
Copy link
Contributor

@straker straker commented Jul 9, 2019 •
edited by jeeyyy
Loading

@WilcoFiers noticed that we should sanitize accessible name attributes on the start node so that whitespace aria attributes don't stop the algorithm.

Reviewer checks

Required fields, to be filled out by PR reviewer(s)

  • Follows the commit message policy, appropriate for next version
  • Has documentation updated, a DU ticket, or requires no documentation change
  • Includes new tests, or was unnecessary
  • Code is reviewed for security by: @JKODU

@straker straker requested a review from a team as a code owner July 9, 2019 20:20
WilcoFiers
WilcoFiers approved these changes Jul 12, 2019
View reviewed changes
Copy link
Contributor

@WilcoFiers WilcoFiers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Steve

@WilcoFiers WilcoFiers merged commit c0bb08c into develop Jul 12, 2019
@WilcoFiers WilcoFiers deleted the accessibleText branch July 12, 2019 10:46
WilcoFiers pushed a commit that referenced this pull request Jul 22, 2019
@straker @WilcoFiers
fix(accessible-text-virtual): sanitize attributes on start node (#1694)
22e4551
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeeyyy jeeyyy jeeyyy approved these changes

@WilcoFiers WilcoFiers WilcoFiers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@straker @WilcoFiers @jeeyyy