fix(multiple-label): no longer raises issue when aria-labelledby overrides how AT views multiple labels

[AutoSponge]

When authors use aria-labelledby on a labeled input, multiple labels will be consumed by AT. In cases where less than all labels are included, the excluded label must have aria-hidden="true".

issue: #689 (don't autoclose, docs needed)

Reviewer checks

Required fields, to be filled out by PR reviewer(s)

• Follows the commit message policy, appropriate for next version
• Has documentation updated, a DU ticket, or requires no documentation change
• Includes new tests, or was unnecessary
• Code is reviewed for security by: dylanb

[straker]

The tests pass as expected, but I got a bit lost in the logic trying to figure out was trying to be tested. Maybe a few comments explaining the whys of the logic would be helpful

satisfied

[straker]

LGTM.

Because of the extent of the rule change, I just want to make sure @WilcoFiers is Ok with the direction before we merge (see #689 (comment)).

[dylanb]

Needs a change to the more info page to explain the logic

[dylanb]

@jeankaplansky please take up the documentation requirement and when the ticket is created, add the link here

[jeankaplansky]

@jeankaplansky please take up the documentation requirement and when the ticket is created, add the link here

@dylanb: Please confirm: documentation requirement exists for both Attest AND axe-core?

I know this is rule help related specifically to this rule: https://dequeuniversity.com/rules/axe/3.2/form-field-multiple-labels

I also know that @AutoSponge told me to refer to this: https://codepen.io/straker/full/PvqONy. We will mark valid the middle 3 code examples that are all green as supported. This tells me we're going to constrain the original "any time there are multiple, visible labels" gist of the current rule help. I'll create a backlog ticket for the documentation reqs and link to this PR as a dependency for the PR being marked complete.

[stephenmathieson]

Merging this. We'll figure out the documentation stuff later on.