fix: Allow div groups for dlitem rule #1284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WilcoFiers
commented
Dec 19, 2018
|
|
||
| // Unlike with UL|OL+LI, DT|DD must be in a DL | ||
| if (parentTagName !== 'DL') { | ||
| return false; | ||
| } | ||
|
|
||
| const parentRole = (parent.getAttribute('role') || '').toLowerCase(); | ||
| if (!parentRole || !axe.commons.aria.isValidRole(parentRole)) { |
There was a problem hiding this comment.
isValidRole is done by aria.getRole(), in case you're wondering.
There was a problem hiding this comment.
I'm surprised it works with the noImplicit: true, can you explain that bit? This applies to native elements as well as bolt-on roles, right? The tests seem to pass, so 🤷♀️
There was a problem hiding this comment.
The requirements here are: It needs to be in a dl, and if that dl has a role attribute, it can only be a list. So what's happening is first I check the parentTagName, and then I check if the explicit role (which is what we get from noImplicit: true is null or 'list'.
marcysutton
approved these changes
Dec 26, 2018
test/checks/lists/dlitem.js
Outdated
| }); | ||
| }); | ||
|
|
||
| it('returns false if the dd/dt is in a div with a role with a dl as grandparent', function() { |
There was a problem hiding this comment.
I'd add with a list role to the test name because that's the important bit
test/checks/lists/dlitem.js
Outdated
| @@ -88,4 +144,17 @@ describe('dlitem', function() { | |||
| assert.isFalse(checks.dlitem.evaluate.apply(null, checkArgs)); | |||
| } | |||
| ); | |||
|
|
|||
| (shadowSupport.v1 ? it : xit)( | |||
| 'should return truewhen the item is grouped in dl > div', | |||
There was a problem hiding this comment.
Add a space to the test name: true when. It should also mention Shadow DOM
marcysutton
previously requested changes
Dec 26, 2018
WilcoFiers
dismissed
marcysutton’s stale review
Comments resolved. Please take another look.
dylanb
approved these changes
Jan 4, 2019
3 tasks
36degrees
added a commit
to alphagov/govuk-frontend
that referenced
this pull request
Sep 8, 2021
We wrap each name-value group in the summary list's `<dl>` with a grouping `<div>` element, which is valid according to the current WHATWG HTML spec [1]. At the time we wrote these tests, this was a relatively recent change to the HTML spec, and the axe rules had not been updated to allow it. Since then, the underlying axe rules have been updated to allow wrapping `<div>` elements [2], so we no longer need to disable the `dlitem` and `definition-list` (released in axe-core 3.2.0 [3]) [1]: https://html.spec.whatwg.org/multipage/grouping-content.html#the-dl-element [2]: dequelabs/axe-core#1284 [3]: https://github.com/dequelabs/axe-core/blob/develop/CHANGELOG.md#320-2019-03-04
36degrees
added a commit
to alphagov/govuk-frontend
that referenced
this pull request
Oct 14, 2021
We wrap each name-value group in the summary list's `<dl>` with a grouping `<div>` element, which is valid according to the current WHATWG HTML spec [1]. At the time we wrote these tests, this was a relatively recent change to the HTML spec, and the axe rules had not been updated to allow it. Since then, the underlying axe rules have been updated to allow wrapping `<div>` elements [2], so we no longer need to disable the `dlitem` and `definition-list` (released in axe-core 3.2.0 [3]) [1]: https://html.spec.whatwg.org/multipage/grouping-content.html#the-dl-element [2]: dequelabs/axe-core#1284 [3]: https://github.com/dequelabs/axe-core/blob/develop/CHANGELOG.md#320-2019-03-04
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow grouping in divs for the dlitem rule.
Closes #1265
Reviewer checks
Required fields, to be filled out by PR reviewer(s)