Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: autocomplete appropriate to handle state terms #1121

Merged
merged 2 commits into from
Sep 7, 2018
Merged

fix: autocomplete appropriate to handle state terms #1121

merged 2 commits into from
Sep 7, 2018

Conversation

jeeyyy
Copy link
Contributor

@jeeyyy jeeyyy commented Sep 6, 2018 •
edited
Loading

This PR handles on | off state terms for autocomplete in check autocomplete-appropriate.

Closes issue:

Reviewer checks

Required fields, to be filled out by PR reviewer(s)

  • Follows the commit message policy, appropriate for next version
  • Has documentation updated, a DU ticket, or requires no documentation change
  • Includes new tests, or was unnecessary
  • Code is reviewed for security by: @WilcoFiers

@jeeyyy jeeyyy requested a review from a team as a code owner September 6, 2018 09:30
jeeyyy
jeeyyy commented Sep 6, 2018
View reviewed changes
test/integration/rules/autocomplete-valid/autocomplete-valid.json
["#pass63"],
["#pass64"],
["#pass65"],
["#pass66"]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, formatting looks spotless in IDE. Github seems to complain on indentation here.

image

@jeeyyy jeeyyy mentioned this pull request Sep 6, 2018
Closed
@jeeyyy
Copy link
Contributor Author

jeeyyy commented Sep 7, 2018

@WilcoFiers - reviewer checks were not filled up. Doing it on your behalf.

@jeeyyy jeeyyy merged commit 35a4d11 into develop Sep 7, 2018
@jeeyyy jeeyyy deleted the fix-autocomplete-valid branch September 7, 2018 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WilcoFiers WilcoFiers WilcoFiers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeeyyy @WilcoFiers