Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: dom.isFocusable mistakenly concludes that invisible elements are unfocusable #647

Closed
0ddfell0w opened this issue Dec 14, 2017 · 0 comments · Fixed by #658
Closed

Bug: dom.isFocusable mistakenly concludes that invisible elements are unfocusable #647

0ddfell0w opened this issue Dec 14, 2017 · 0 comments · Fixed by #658

Comments

@0ddfell0w
Copy link
Contributor

dom.isFocusable will return false for any element that isn't visible, including elements that are clipped or simply positioned off screen. In reality, those elements are focusable. Demo: https://codepen.io/0ddfell0w/pen/KZpZVZ
@WilcoFiers WilcoFiers mentioned this issue Dec 15, 2017
Closed
0ddfell0w added a commit to 0ddfell0w/axe-core that referenced this issue Dec 15, 2017
@0ddfell0w
fix(commons/dom): change isFocusable to use unfocusableBecauseHidden
8fa0066 
method instead of isVisible

Adds functionality for detecting when hidden elements are still
focusable or in focus order.

fixes dequelabs#647
@0ddfell0w 0ddfell0w mentioned this issue Dec 15, 2017
Closed
0ddfell0w added a commit to 0ddfell0w/axe-core that referenced this issue Dec 15, 2017
@0ddfell0w
fix(commons/dom): change isFocusable to use unfocusableBecauseHidden
60fe2c8 
method instead of isVisible

Adds functionality for detecting when hidden elements are still
focusable or in focus order.

fixes dequelabs#647
0ddfell0w added a commit to 0ddfell0w/axe-core that referenced this issue Dec 15, 2017
@0ddfell0w
fix(commons/dom): change isFocusable to use unfocusableBecauseHidden
783920e 
method instead of isVisible

Adds functionality for detecting when hidden elements are still
focusable or in focus order.

fixes dequelabs#647
0ddfell0w added a commit to 0ddfell0w/axe-core that referenced this issue Dec 15, 2017
@0ddfell0w
fix(commons/dom): change isFocusable to use unfocusableBecauseHidden
28de37b 
method instead of isVisible

Adds functionality for detecting when hidden elements are still
focusable or in focus order.

fixes dequelabs#647
0ddfell0w added a commit to 0ddfell0w/axe-core that referenced this issue Dec 15, 2017
@0ddfell0w
fix(commons/dom): change isFocusable to check visibility in screenreader
648840e 
mode

fixes dequelabs#647
@0ddfell0w 0ddfell0w mentioned this issue Dec 15, 2017
Closed
0ddfell0w added a commit to 0ddfell0w/axe-core that referenced this issue Dec 15, 2017
@0ddfell0w
fix(commons/dom): change isFocusable to check visibility in screenreader
ab16de5 
mode

fixes dequelabs#647
0ddfell0w added a commit to 0ddfell0w/axe-core that referenced this issue Dec 15, 2017
@0ddfell0w
fix(commons/dom): change isFocusable to check visibility in screenreader
1610a82 
mode

fixes dequelabs#647
0ddfell0w added a commit to 0ddfell0w/axe-core that referenced this issue Dec 18, 2017
@0ddfell0w
fix(commons/dom): fix isFocusable functions by checking screenreader
ea6f133 
visibility and enabledness

Adds tests for disabled/AT-hidden elements with tabindex

fixes dequelabs#647
@0ddfell0w 0ddfell0w mentioned this issue Dec 18, 2017
Merged
0ddfell0w added a commit to 0ddfell0w/axe-core that referenced this issue Dec 18, 2017
@0ddfell0w
fix(commons/dom): fix isFocusable functions by checking screenreader
48e7326 
visibility and enabledness

Adds tests for disabled/AT-hidden elements with tabindex

fixes dequelabs#647
0ddfell0w added a commit to 0ddfell0w/axe-core that referenced this issue Dec 19, 2017
@0ddfell0w
fix(commons/dom): fix isFocusable functions by checking screenreader
0baf768 
visibility and enabledness

Adds tests for disabled/AT-hidden elements with tabindex

fixes dequelabs#647
@WilcoFiers WilcoFiers mentioned this issue Dec 21, 2017
Closed
WilcoFiers pushed a commit that referenced this issue Dec 21, 2017
@0ddfell0w @WilcoFiers
fix(commons/dom): fix isFocusable functions by checking screenreader (#…
c665d0b 
…658)

visibility and enabledness

Adds tests for disabled/AT-hidden elements with tabindex

fixes #647
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@0ddfell0w