Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add summary-name rule #4510

Closed
WilcoFiers opened this issue Jun 21, 2024 · 1 comment · Fixed by #4511 · May be fixed by Stanislav1975/sitespeed.io#11, Stanislav1975/sitespeed.io#12 or organich/lighthouse#4
Closed

Add summary-name rule #4510

WilcoFiers opened this issue Jun 21, 2024 · 1 comment · Fixed by #4511 · May be fixed by Stanislav1975/sitespeed.io#11, Stanislav1975/sitespeed.io#12 or organich/lighthouse#4
Assignees
@WilcoFiers
Labels
feat New feature or enhancement rules Issue or false result from an axe-core rule
Milestone
Axe-core 4.10

Comments

@WilcoFiers
Copy link
Contributor

Axe-core should be able to fail this. i think we need a new rule for it:

<details>
  <summary></summary>
  <p>Hello world</p>
</details>
@WilcoFiers WilcoFiers added feat New feature or enhancement rules Issue or false result from an axe-core rule labels Jun 21, 2024
@WilcoFiers WilcoFiers self-assigned this Jun 21, 2024
@WilcoFiers WilcoFiers mentioned this issue Jun 21, 2024
Merged
WilcoFiers added a commit that referenced this issue Jul 1, 2024
@WilcoFiers
feat(new-rule): summary elements must have an accessible name (#4511)
0d8a99e 
This rule checks that summary elements have an accessible name, through
text content, aria-label(ledby) or title. It skips summary elements that
are not used as controls for `details`, or if its `details` element has
no content.

Closes: #4510
@WilcoFiers WilcoFiers added this to the Axe-core 4.10 milestone Jul 1, 2024
@padmavemulapati
Copy link

Verified with the latest dev branch code, seeing summary-name rule fail for the code snippet

<details>
  <summary></summary>
  <p>Hello world</p>
</details>
image

As this is the new rule in axe-core4.10.0, we cannt see this fail with the earlier versions:

image

Environment:

Label Value
Product axe-core
Version 4.10.0(Dev Branch Code base
OS-Details _MAC- 14.4.1 _
BrowserDetails Chrome Version 126.0.4

@attest-team-ci attest-team-ci mentioned this issue Jul 29, 2024
Merged
WilcoFiers added a commit that referenced this issue Jul 29, 2024
@WilcoFiers
chore(release): v4.10.0 (#4545)
c49c8ea 
##
[4.10.0](v4.9.1...v4.10.0)
(2024-07-29)

### Features

- **new-rule:** summary elements must have an accessible name
([#4511](#4511))
([0d8a99e](0d8a99e)),
closes [#4510](#4510)

### Bug Fixes

- **all-rules:** fix flakey all-rules firefox test
([#4467](#4467))
([3f13aa1](3f13aa1))
- **aria-allowed-attr:** allow aria-multiline=false for element with
contenteditable
([#4537](#4537))
([f019068](f019068))
- **aria-allowed-attr:** allow aria-required=false when normally not
allowed ([#4532](#4532))
([2e242e1](2e242e1))
- **aria-prohibited-attr:** allow aria-label/ledby on decendants of
widget ([#4541](#4541))
([07c5d91](07c5d91))
- **aria-roledescription:** keep disabled with { runOnly: 'wcag2a' }
([#4526](#4526))
([5b4cb9d](5b4cb9d)),
closes [#4523](#4523)
- **autocomplete-valid:** incomplete for invalid but safe values
([#4500](#4500))
([e31a974](e31a974)),
closes [#4492](#4492)
- **build:** limit locales to valid files when using the --all-lang
option ([#4486](#4486))
([d3db593](d3db593)),
closes [#4485](#4485)
- colorio.js patch mocking CSS
([#4456](#4456))
([3ef9353](3ef9353)),
closes [#4400](#4400)
- correct typos in texts
([#4499](#4499))
([11fad59](11fad59))
- **landmark-unique:** follow spec, aside -> landmark
([#4469](#4469))
([e32f803](e32f803)),
closes [#4460](#4460)
- **required-attr:** allow aria-valuetext on slider instead of valuenow
([#4518](#4518))
([135898b](135898b)),
closes [#4515](#4515)

This PR was opened by a robot 🤖 🎉
@Stanislav1975 Stanislav1975 mentioned this issue Aug 19, 2024
Open
@Stanislav1975 Stanislav1975 mentioned this issue Sep 9, 2024
Open
@organich organich mentioned this issue Sep 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@WilcoFiers WilcoFiers

Labels
feat New feature or enhancement rules Issue or false result from an axe-core rule
Projects
None yet
Milestone
Axe-core 4.10
2 participants
@WilcoFiers @padmavemulapati