Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

incomplete nodes should have impact #356

Closed
WilcoFiers opened this issue Jun 14, 2017 · 2 comments
Closed

incomplete nodes should have impact #356

WilcoFiers opened this issue Jun 14, 2017 · 2 comments

Comments

@WilcoFiers
Copy link
Contributor

The incomplete nodes currently don't have their impact property set. Makes sense, but then when it's reviewed, and set to violation, the impact is undefined. It's probably best to pass the potential impact along so it can be used when it was determined the result is a violation.
@marcysutton
Copy link
Contributor

marcysutton commented Jun 15, 2017 •
edited
Loading

They do have it set from what I can tell. I just ran axe-core on a page with incomplete color contrast issues and the impact is set to serious in both the rule and the check.

Edit: I do see it, on the nodes only. Impact is set in 3 places: at the violation level, the node, and the check. Incomplete isn't passing it through at the node level.

@WilcoFiers
Copy link
Contributor Author

Should be resolved with #465.

mrtnvh pushed a commit to mrtnvh/axe-core that referenced this issue Nov 24, 2023
@WilcoFiers
feat: Add .setLegacyMode (dequelabs#356)
f9d021b 
* feat(wdjs): Add .setLegacyMode

* feat(wdio): add setLegacyMode

* feat(puppeteer): Add setLegacyMode

* feat(playwright): Add setLegacyMode

* chore: upgrade package-lock
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@WilcoFiers @marcysutton