Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider role in the label rule #2458

Closed
WilcoFiers opened this issue Aug 16, 2020 · 2 comments
Closed

Consider role in the label rule #2458

WilcoFiers opened this issue Aug 16, 2020 · 2 comments
Labels
ACT Rules false negative good first issue For first-time contributors rules Issue or false result from an axe-core rule

Comments

@WilcoFiers
Copy link
Contributor

The following code snippets should not fail the label rule. This can be fixed by adding the role-none and role-presentation checks to that rule (as well as a few integration tests).

<input role="none" disabled />
<input role="presentation" disabled />
@WilcoFiers WilcoFiers added rules Issue or false result from an axe-core rule ACT Rules good first issue For first-time contributors false negative labels Aug 16, 2020
@WilcoFiers WilcoFiers changed the title Consider role in the label rule (beginner) Consider role in the label rule Aug 16, 2020
42tte added a commit to 42tte/axe-core that referenced this issue Aug 19, 2020
@42tte
fix(label): pass when role none or presentation
6464600 
Pass label rule when role none or presentation

Closes dequelabs#2458
@42tte 42tte mentioned this issue Aug 19, 2020
Merged
2 tasks
@straker straker reopened this Aug 19, 2020
@padmavemulapati
Copy link

Verified in the latest code - label is passing when role-none and role-presentation <input role="none" disabled /> and also
<input role="presentation" disabled />
and at the same time failure is there for aria-allowed-attribute , which is expected.
image

straker pushed a commit that referenced this issue Sep 8, 2020
@42tte @straker
fix(label): pass when role none or presentation (#2464)
1d3c2fc 
Pass label rule when role none or presentation

Closes #2458
@straker
Copy link
Contributor

straker commented Sep 25, 2020

No docs required

@straker straker closed this as completed Sep 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ACT Rules false negative good first issue For first-time contributors rules Issue or false result from an axe-core rule
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@WilcoFiers @straker @padmavemulapati