Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove "restoreScroll" option #2388

Closed
WilcoFiers opened this issue Jul 16, 2020 · 2 comments
Closed

Remove "restoreScroll" option #2388

WilcoFiers opened this issue Jul 16, 2020 · 2 comments
Assignees
@straker
Labels
core Issues in the core code (lib/core) docs Documentation changes tech debt Technical debt related tasks
Milestone
Axe-core 4.0

Comments

@WilcoFiers
Copy link
Contributor

Because the color-contrast rule no longer scrolls, the restoreScroll option does nothing. This should be taken out of core and out of the docs. I don't think we need to deprecate it either, just as long as passing it doesn't cause axe-core to crash.
@WilcoFiers WilcoFiers added core Issues in the core code (lib/core) docs Documentation changes tech debt Technical debt related tasks labels Jul 16, 2020
@WilcoFiers WilcoFiers added this to the Axe-core 4.0 milestone Jul 16, 2020
@straker straker mentioned this issue Jul 22, 2020
Merged
2 tasks
@straker straker self-assigned this Jul 22, 2020
@padmavemulapati
Copy link

Seeing the changes for color-contrast issue , verified with latest axe-coconut
image

@jeankaplansky
Copy link
Contributor

changelog still has references to restoreScroll from previous versions.
No user-facing docs required.

@engelsdamien engelsdamien mentioned this issue Sep 16, 2020
Merged
2 tasks
@StephenEsser StephenEsser mentioned this issue Oct 27, 2020
Merged
@mohanraj-r mohanraj-r mentioned this issue Nov 18, 2020
Merged
2 tasks
This was referenced Oct 17, 2022
Closed
Merged
@dbjorge dbjorge mentioned this issue Feb 21, 2023
Merged
4 tasks
dbjorge added a commit to microsoft/accessibility-insights-web that referenced this issue Feb 22, 2023
@dbjorge
chore: remove references to obsolete restoreScroll axe-core option (#…
3eff674 
…6448)

#### Details

`axe-core` removed its `restoreScroll` option in mid-2020, when they
updated the only rule that scrolled the page to no longer ever do that
in [PR 2388](dequelabs/axe-core#2388).

This PR removes the obsolete option from our axe-config.

##### Motivation

* Code cleanup, axe-core doesn't care whether the option is passed or
not.
* Preparation for [using the axe-config output in
service](microsoft/accessibility-insights-service#2402)

##### Context

n/a

#### Pull request checklist
<!-- If a checklist item is not applicable to this change, write "n/a"
in the checkbox -->
- [n/a] Addresses an existing issue: #0000
- [x] Ran `yarn fastpass`
- [x] Added/updated relevant unit test(s) (and ran `yarn test`)
- [x] Verified code coverage for the changes made. Check coverage report
at: `<rootDir>/test-results/unit/coverage`
- [x] PR title *AND* final merge commit title both start with a semantic
tag (`fix:`, `chore:`, `feat(feature-name):`, `refactor:`). See
`CONTRIBUTING.md`.
- [n/a] (UI changes only) Added screenshots/GIFs to description above
- [n/a] (UI changes only) Verified usability with NVDA/JAWS
abassey2 pushed a commit to msa2984/accessibility-insights-web that referenced this issue Feb 22, 2023
@dbjorge
chore: remove references to obsolete restoreScroll axe-core option (m…
a1948c7 
…icrosoft#6448)

#### Details

`axe-core` removed its `restoreScroll` option in mid-2020, when they
updated the only rule that scrolled the page to no longer ever do that
in [PR 2388](dequelabs/axe-core#2388).

This PR removes the obsolete option from our axe-config.

##### Motivation

* Code cleanup, axe-core doesn't care whether the option is passed or
not.
* Preparation for [using the axe-config output in
service](microsoft/accessibility-insights-service#2402)

##### Context

n/a

#### Pull request checklist
<!-- If a checklist item is not applicable to this change, write "n/a"
in the checkbox -->
- [n/a] Addresses an existing issue: #0000
- [x] Ran `yarn fastpass`
- [x] Added/updated relevant unit test(s) (and ran `yarn test`)
- [x] Verified code coverage for the changes made. Check coverage report
at: `<rootDir>/test-results/unit/coverage`
- [x] PR title *AND* final merge commit title both start with a semantic
tag (`fix:`, `chore:`, `feat(feature-name):`, `refactor:`). See
`CONTRIBUTING.md`.
- [n/a] (UI changes only) Added screenshots/GIFs to description above
- [n/a] (UI changes only) Verified usability with NVDA/JAWS
abassey2 pushed a commit to msa2984/accessibility-insights-web that referenced this issue Feb 22, 2023
@dbjorge
chore: remove references to obsolete restoreScroll axe-core option (m…
7f963ff 
…icrosoft#6448)

#### Details

`axe-core` removed its `restoreScroll` option in mid-2020, when they
updated the only rule that scrolled the page to no longer ever do that
in [PR 2388](dequelabs/axe-core#2388).

This PR removes the obsolete option from our axe-config.

##### Motivation

* Code cleanup, axe-core doesn't care whether the option is passed or
not.
* Preparation for [using the axe-config output in
service](microsoft/accessibility-insights-service#2402)

##### Context

n/a

#### Pull request checklist
<!-- If a checklist item is not applicable to this change, write "n/a"
in the checkbox -->
- [n/a] Addresses an existing issue: #0000
- [x] Ran `yarn fastpass`
- [x] Added/updated relevant unit test(s) (and ran `yarn test`)
- [x] Verified code coverage for the changes made. Check coverage report
at: `<rootDir>/test-results/unit/coverage`
- [x] PR title *AND* final merge commit title both start with a semantic
tag (`fix:`, `chore:`, `feat(feature-name):`, `refactor:`). See
`CONTRIBUTING.md`.
- [n/a] (UI changes only) Added screenshots/GIFs to description above
- [n/a] (UI changes only) Verified usability with NVDA/JAWS
@robinwhittleton robinwhittleton mentioned this issue Apr 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@straker straker

Labels
core Issues in the core code (lib/core) docs Documentation changes tech debt Technical debt related tasks
Projects
None yet
Milestone
Axe-core 4.0
Development

No branches or pull requests
4 participants
@WilcoFiers @straker @jeankaplansky @padmavemulapati