fix(is-valid-autocomplete): allow autocomplete="one-time-code" #2336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This autocomplete value can be used by some browsers to automatically fill in the value after receiving a one-time-code for 2-factor authentication. More info: - whatwg/html#4573 - https://developer.apple.com/documentation/security/password_autofill/enabling_password_autofill_on_an_html_input_element - https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes/autocomplete#Values - https://www.twilio.com/blog/html-attributes-two-factor-authentication-autocomplete
|
|
straker
approved these changes
Jun 30, 2020
There was a problem hiding this comment.
Thanks for the pr. Verified in https://html.spec.whatwg.org/multipage/form-control-infrastructure.html#autofill as well.
|
Just need to sign the license/cla and we get this merged in. |
|
Dikirim dari Outlook Seluler
…________________________________
From: Steven Lambert <[email protected]>
Sent: Tuesday, June 30, 2020 10:45:15 PM
To: dequelabs/axe-core <[email protected]>
Cc: Subscribed <[email protected]>
Subject: Re: [dequelabs/axe-core] Allow autocomplete="one-time-code" (#2336)
Just need to sign the license/cla and we get this merged in.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub<#2336 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ALVWM244LJLVPMAWFVFFP3TRZICAXANCNFSM4OMLK77A>.
|
|
@straker CLA signed, thanks! |
straker
changed the title
|
@backwardok Yep, should have made it into the 4.0.0 release. |
|
Great, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This autocomplete value can be used by some browsers to automatically
fill in the value after receiving a one-time-code for 2-factor
authentication. More info:
autocomplete=one-time-code. Fixes whatwg/html#3745 whatwg/html#4573Closes issue: #2335
Reviewer checks
Required fields, to be filled out by PR reviewer(s)