Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can impact be null? #2313

Closed
stephenmathieson opened this issue Jun 18, 2020 · 1 comment · Fixed by #2321
Closed

Can impact be null? #2313

stephenmathieson opened this issue Jun 18, 2020 · 1 comment · Fixed by #2321
Assignees
@WilcoFiers

Comments

@stephenmathieson
Copy link
Member

The Attest products often mark impact: null in their "findings". Is this supported by axe-core?

If so, can we update its axe.d.ts file to allow this?
@stephenmathieson stephenmathieson mentioned this issue Jun 18, 2020
Closed
@straker
Copy link
Contributor

straker commented Jun 18, 2020

As far as I understand it, impact is never null in axe codebase. But @WilcoFiers would be better one to ask.

stephenmathieson added a commit that referenced this issue Jun 24, 2020
@stephenmathieson
fix(types): Allow impact to be null
72028ad 
Closes #2313
@stephenmathieson stephenmathieson mentioned this issue Jun 24, 2020
Merged
2 tasks
stephenmathieson added a commit that referenced this issue Jun 24, 2020
@stephenmathieson
fix(types): Allow impact to be null (#2321)
757aacd 
Closes #2313
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@WilcoFiers WilcoFiers

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(types): Allow impact to be null dequelabs/axe-core
3 participants
@WilcoFiers @stephenmathieson @straker