Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(td-has-headers): don't fail for empty headers attribute #2095

Merged
merged 3 commits into from
Mar 18, 2020
Merged

fix(td-has-headers): don't fail for empty headers attribute #2095

merged 3 commits into from
Mar 18, 2020

Conversation

straker
Copy link
Contributor

@straker straker commented Mar 11, 2020 •
edited by WilcoFiers
Loading

Part 1 of 2 (part 2: #2096)

Partially closes issue: #2039

Reviewer checks

Required fields, to be filled out by PR reviewer(s)

  • Follows the commit message policy, appropriate for next version
  • Code is reviewed for security

@straker straker requested a review from a team as a code owner March 11, 2020 22:45
@straker straker mentioned this pull request Mar 11, 2020
Merged
2 tasks
WilcoFiers
WilcoFiers previously requested changes Mar 12, 2020
View reviewed changes
lib/commons/table/get-headers.js Outdated Show resolved Hide resolved
WilcoFiers
WilcoFiers previously requested changes Mar 13, 2020
View reviewed changes
lib/commons/table/get-headers.js Outdated Show resolved Hide resolved
@straker straker merged commit 7952a37 into develop Mar 18, 2020
@straker straker deleted the tdHasHeaders branch March 18, 2020 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WilcoFiers WilcoFiers WilcoFiers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@straker @WilcoFiers