Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

td-has-header should not always fail <td headers=""> #2039

Closed
WilcoFiers opened this issue Feb 11, 2020 · 4 comments
Closed

td-has-header should not always fail <td headers=""> #2039

WilcoFiers opened this issue Feb 11, 2020 · 4 comments
Assignees
Labels
fix Bug fixes rules Issue or false result from an axe-core rule

Comments

@WilcoFiers
Copy link
Contributor

WilcoFiers commented Feb 11, 2020

The td-has-header rule seems to consistently fail <td headers=""> elements. We have some test data that shows that AT will fall back to column / rowheaders in this situation.

<table>
  <tr>
    <th scope="col">Projects</th>
    <th scope="col">Progress</th>
  </tr>
  <tr>
    <td headers="">My Project</td>
    <td>15%</td>
  </tr>
</table>

IE + JAWS: Works
Chrome + JAWS: Works
Firefox + NVDA: Works
Safari + VO: Works

I think we should report this for review. Axe-core should probably still fail if the headers attribute references something that doesn't exist, or something outside the table.

@WilcoFiers WilcoFiers added fix Bug fixes rules Issue or false result from an axe-core rule labels Feb 11, 2020
@jeeyyy
Copy link
Contributor

jeeyyy commented Feb 18, 2020

@WilcoFiers did you mean the rule td-headers-attr here?

@WilcoFiers
Copy link
Contributor Author

Nope. The problem here is that td-has-header stops looking if it finds a headers attribute without associated headers. It should continue looking for column/rowheaders. This is not according to spec, but we have test data showing this happens consistently.

@padmavemulapati
Copy link

Its verified as part of the verification of https://github.com/dequelabs/axe-core/issues/2013 , yes we are seeing the results as incomplete which is expected as per the change done here in this ticket.
image (11)

@straker
Copy link
Contributor

straker commented Apr 1, 2020

No docs needed

@straker straker closed this as completed Apr 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fixes rules Issue or false result from an axe-core rule
Projects
None yet
Development

No branches or pull requests

4 participants