Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(i18n): add Danish (da-DK) translation #1876

Merged
merged 3 commits into from
Jan 6, 2020

Conversation

ddfreiling
Copy link
Contributor

@ddfreiling ddfreiling commented Oct 30, 2019

Adds Danish localization of Ace.

Thanks for your great work from Nota in Denmark.

Reviewer checks

Required fields, to be filled out by PR reviewer(s)

  • Follows the commit message policy, appropriate for next version
  • Code is reviewed for security

@ddfreiling ddfreiling requested a review from a team as a code owner October 30, 2019 20:09
@CLAassistant
Copy link

CLAassistant commented Oct 30, 2019

CLA assistant check
All committers have signed the CLA.

@straker
Copy link
Contributor

straker commented Oct 30, 2019

Thanks for the pr! We'll see if we can find anyone who speaks Danish to look it over.

@WilcoFiers
Copy link
Contributor

@ddfreiling have you had a chance to process the feedback you received from Marianne yet?

@ddfreiling
Copy link
Contributor Author

@WilcoFiers I'll be able to do it this weekend or monday.

@WilcoFiers
Copy link
Contributor

@ddfreiling any luck? No rush though, just wondering if there's something I could help out with.

@ddfreiling
Copy link
Contributor Author

@ddfreiling any luck? No rush though, just wondering if there's something I could help out with.

Been very busy at work, will try and look at it tonight.

@ddfreiling
Copy link
Contributor Author

@WilcoFiers Translation has finally been reviewed and improved based on review by Marianne

@WilcoFiers WilcoFiers merged commit fb6fc41 into dequelabs:develop Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants