Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(l10n): add Danish localization #302

Merged
merged 3 commits into from
Mar 31, 2020

Conversation

ddfreiling
Copy link
Contributor

Note: In the English translation I assumed in packages/ace-report-axe/src/l10n/locales/da.json that it was a mistake having the key "area-alt" translated to "Image maps", is this correct?

I will have Marianne, who reviewed my Danish translation of axe-core (dequelabs/axe-core#1876), review this as well. I will let you know when it is done.

Copy link

@MyDK MyDK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ddfreiling - I agree with your translation, and suggest these few changes.

"metadataviolation": {
"kbtitle": "Metadata for tilgængelighed fra Schema.org",
"resdesc": "Tilføj et '{{name}}' metadata-element til pakke-dokumentet",
"ruledesc": "Publikationen skal angive et '{{name}}' metadata element",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"ruledesc": "Publikationen skal angive et '{{name}}' metadata-element",

"metadataprintpagenumbers": {
"kbtitle": "Metadata for tilgængelighed fra Schema.org",
"resdesc": "Tilføj en liste over sider til navigations-dokumentet",
"ruledesc": "Når tilgængeligheds-egenskaben 'printPageNumbers' bruges, bør navigations dokumentet indeholde en liste over sider",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"ruledesc": "Når tilgængeligheds-egenskaben 'printPageNumbers' bruges, bør navigations-dokumentet indeholde en liste over sider",

"rule": "Regel",
"ruleset": "Regelsæt",
"serious": "Seriøs",
"snippet": "Stump:",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should there be a colon here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have kept colon, where it occurred at the end of the text in the English translation

"color-contrast": "Farve",
"definition-list": "Lister",
"dlitem": "Lister",
"document-title": "Sidens Titel",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"document-title": "Sidens titel",

"empty-heading": "Overskrifter",
"epub-type-has-matching-role": "ARIA roller",
"frame-title": "Indsatte Sider",
"frame-title-unique": "Indsatte Sider",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"frame-title-unique": "Indsatte sider",

"duplicate-id": "Identifikator",
"empty-heading": "Overskrifter",
"epub-type-has-matching-role": "ARIA roller",
"frame-title": "Indsatte Sider",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"frame-title": "Indsatte sider",

"testdesc": "Sikrer at kilden til sideskift er identificeret"
},
"titleviolation": {
"kbtitle": "EPUB Titel",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"kbtitle": "EPUB titel",

@ddfreiling
Copy link
Contributor Author

Updated after review, should be ready for merge now. Thanks @MyDK !

@danielweck
Copy link
Member

Hello Daniel, thank you for this contribution!
Would you be interested in translating Ace App (the desktop user interface for Ace)?
If so, there are instructions in this wiki page:
https://github.com/daisy/ace-gui/wiki/Localization
Regards, Daniel

@danielweck danielweck changed the base branch from master to feat/l10n-da March 31, 2020 11:04
@danielweck
Copy link
Member

Merging this PR into a staging branch feat/l10n-da in preparation for final merging into master and ace-next (checks pending)
Thank you! I will let you know how it goes.

@danielweck danielweck merged commit 40c66f0 into daisy:feat/l10n-da Mar 31, 2020
danielweck added a commit that referenced this pull request Mar 31, 2020
@danielweck
Copy link
Member

Now merged into master, thank you very much!
#316

@ddfreiling
Copy link
Contributor Author

No problem! I will look into translating the Ace App, when I find the time.

  • Best regards, Nota in Denmark

@danielweck
Copy link
Member

Hello, I have now also merged your Danish translation into the "Ace next" branch ( #314 ), which introduces 2 new labels. So, could you please take a look and let me know what strings to use, and I will fix the branch:

72c8ded#diff-5530ffd4b88ca1f4ad6ea40abbc0f976

Thank you!!

@ddfreiling
Copy link
Contributor Author

"audio-caption": "Lyd",
...
"style": "Styling",

Do you want a PR for this?

@danielweck
Copy link
Member

danielweck commented Mar 31, 2020

No thank you, I am integrating changes now :)

UPDATE: 33d9189

@danielweck
Copy link
Member

Note that I added credits in the wiki page with your contributor GitHub handle:
https://github.com/daisy/ace/wiki/Localization

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants