-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(l10n): add Danish localization #302
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ddfreiling - I agree with your translation, and suggest these few changes.
"metadataviolation": { | ||
"kbtitle": "Metadata for tilgængelighed fra Schema.org", | ||
"resdesc": "Tilføj et '{{name}}' metadata-element til pakke-dokumentet", | ||
"ruledesc": "Publikationen skal angive et '{{name}}' metadata element", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"ruledesc": "Publikationen skal angive et '{{name}}' metadata-element",
"metadataprintpagenumbers": { | ||
"kbtitle": "Metadata for tilgængelighed fra Schema.org", | ||
"resdesc": "Tilføj en liste over sider til navigations-dokumentet", | ||
"ruledesc": "Når tilgængeligheds-egenskaben 'printPageNumbers' bruges, bør navigations dokumentet indeholde en liste over sider", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"ruledesc": "Når tilgængeligheds-egenskaben 'printPageNumbers' bruges, bør navigations-dokumentet indeholde en liste over sider",
"rule": "Regel", | ||
"ruleset": "Regelsæt", | ||
"serious": "Seriøs", | ||
"snippet": "Stump:", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should there be a colon here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have kept colon, where it occurred at the end of the text in the English translation
"color-contrast": "Farve", | ||
"definition-list": "Lister", | ||
"dlitem": "Lister", | ||
"document-title": "Sidens Titel", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"document-title": "Sidens titel",
"empty-heading": "Overskrifter", | ||
"epub-type-has-matching-role": "ARIA roller", | ||
"frame-title": "Indsatte Sider", | ||
"frame-title-unique": "Indsatte Sider", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"frame-title-unique": "Indsatte sider",
"duplicate-id": "Identifikator", | ||
"empty-heading": "Overskrifter", | ||
"epub-type-has-matching-role": "ARIA roller", | ||
"frame-title": "Indsatte Sider", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"frame-title": "Indsatte sider",
"testdesc": "Sikrer at kilden til sideskift er identificeret" | ||
}, | ||
"titleviolation": { | ||
"kbtitle": "EPUB Titel", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"kbtitle": "EPUB titel",
Updated after review, should be ready for merge now. Thanks @MyDK ! |
Hello Daniel, thank you for this contribution! |
Merging this PR into a staging branch |
Now merged into |
No problem! I will look into translating the Ace App, when I find the time.
|
Hello, I have now also merged your Danish translation into the "Ace next" branch ( #314 ), which introduces 2 new labels. So, could you please take a look and let me know what strings to use, and I will fix the branch: 72c8ded#diff-5530ffd4b88ca1f4ad6ea40abbc0f976 Thank you!! |
Do you want a PR for this? |
No thank you, I am integrating changes now :) UPDATE: 33d9189 |
Note that I added credits in the wiki page with your contributor GitHub handle: |
Note: In the English translation I assumed in
packages/ace-report-axe/src/l10n/locales/da.json
that it was a mistake having the key "area-alt" translated to "Image maps", is this correct?I will have Marianne, who reviewed my Danish translation of axe-core (dequelabs/axe-core#1876), review this as well. I will let you know when it is done.