-
Notifications
You must be signed in to change notification settings - Fork 779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove aria-required-children for role="tree" #1444
Comments
We ran into this issue as well in a product that allows user interaction to insert tree items. The empty There are examples of empty trees existing on desktop applications in Windows applications, so it's not a completely unknown pattern. An example might be in something like this: https://www.lightningdesignsystem.com/components/dueling-picklist/ where instead of listboxes there are selectible tree views, and all items are removed from one side. |
I agree. I think generally the aria-required-children rule isn't quite right and should probably be more of an "allowed children" type rule, similar to what we've done with the list rules. Thank you for reporting. We'll definitely pick this up. |
@WilcoFiers how exactly would you like to handle this? It seems related to #874 and #383 |
@straker The aria-required-children check has an option for
That would make only the following roles fail if they are left empty:
|
…timeouts By disabling the following rules we can expect tests to run ~4 seconds faster. Tested with https://crrev.com/c/1635874. Disabled slow rules: - color-contrast - image-redundant-alt Disabled rules with bugs: - aria-required-children, see: dequelabs/axe-core#1444 Disabled low value rules: - meta-refresh - blink - audio-caption - object-alt - video-caption - video-description - radiogroup - marquee - html-has-lang - html-lang-valid - meta-viewport-large - meta-viewport - valid-lang Any test may override this list to re-enable rules on specific UI. Bug: 963183 Change-Id: I9094360c73c45168df4ac99aea0d659103950eb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638125 Commit-Queue: John Emau <[email protected]> Reviewed-by: Joel Einbinder <[email protected]> Cr-Commit-Position: refs/heads/master@{#673389}
…timeouts By disabling the following rules we can expect tests to run ~4 seconds faster. Tested with https://crrev.com/c/1635874. Disabled slow rules: - color-contrast - image-redundant-alt Disabled rules with bugs: - aria-required-children, see: dequelabs/axe-core#1444 Disabled low value rules: - meta-refresh - blink - audio-caption - object-alt - video-caption - video-description - radiogroup - marquee - html-has-lang - html-lang-valid - meta-viewport-large - meta-viewport - valid-lang Any test may override this list to re-enable rules on specific UI. Bug: 963183 Change-Id: I9094360c73c45168df4ac99aea0d659103950eb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638125 Commit-Queue: John Emau <[email protected]> Reviewed-by: Joel Einbinder <[email protected]> Cr-Original-Commit-Position: refs/heads/master@{#673389} Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src Cr-Mirrored-Commit: 97b5560ae4622a82e2dddd8875dbb9bc6a6810f0
…timeouts By disabling the following rules we can expect tests to run ~4 seconds faster. Tested with https://crrev.com/c/1635874. Disabled slow rules: - color-contrast - image-redundant-alt Disabled rules with bugs: - aria-required-children, see: dequelabs/axe-core#1444 Disabled low value rules: - meta-refresh - blink - audio-caption - object-alt - video-caption - video-description - radiogroup - marquee - html-has-lang - html-lang-valid - meta-viewport-large - meta-viewport - valid-lang Any test may override this list to re-enable rules on specific UI. Bug: 963183 Change-Id: I9094360c73c45168df4ac99aea0d659103950eb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638125 Commit-Queue: John Emau <[email protected]> Reviewed-by: Joel Einbinder <[email protected]> Cr-Commit-Position: refs/heads/master@{#673389}
Expectation:
should generate no errors.
Actual: It generates the following error:
Motivation: A tree that has no leaves is still a tree, and therefore
role="treeitem"
should not be a required child of an element ofrole="tree"
.axe-core version: 3.0.0-alpha1, 3.1.1
The text was updated successfully, but these errors were encountered: