Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose the element that is tested when a rule throws #1317

Closed
WilcoFiers opened this issue Jan 16, 2019 · 1 comment
Closed

Expose the element that is tested when a rule throws #1317

WilcoFiers opened this issue Jan 16, 2019 · 1 comment
Labels
core Issues in the core code (lib/core) feat New feature or enhancement

Comments

@WilcoFiers
Copy link
Contributor

When an error occurs while running a rule, axe-core catches that error and puts it in incomplete. What it doesn't do is expose which element it was testing when that error happened. Exposing this will help with debugging.
@WilcoFiers WilcoFiers added feat New feature or enhancement core Issues in the core code (lib/core) labels Jan 16, 2019
@stephenmathieson
Copy link
Member

Taking a look at this. Seems like all we'll need to do is add .node here.

stephenmathieson added a commit that referenced this issue Jan 16, 2019
@stephenmathieson
feat: add a reference to the node a rule failed on
4612754 
This patch adds a `.node` reference to an errored rule result. This can be used to determine which node the rule errored on and will be helpful for debugging purposes.

Closes #1317.
@stephenmathieson stephenmathieson mentioned this issue Jan 16, 2019
Merged
4 tasks
WilcoFiers pushed a commit that referenced this issue Jan 21, 2019
@stephenmathieson @WilcoFiers
feat: add a reference to the node a rule failed on (#1321)
68741de 
This patch adds a `.node` reference to an errored rule result. This can be used to determine which node the rule errored on and will be helpful for debugging purposes.

Closes #1317.

## Reviewer checks

**Required fields, to be filled out by PR reviewer(s)**
- [x] Follows the commit message policy, appropriate for next version
- [x] Has documentation updated, a DU ticket, or requires no documentation change
- [x] Includes new tests, or was unnecessary
- [x] Code is reviewed for security by: @WilcoFiers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
core Issues in the core code (lib/core) feat New feature or enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@WilcoFiers @stephenmathieson