Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dom.isFocusable function (PR#1211) #1208

Closed
jeeyyy opened this issue Oct 28, 2018 · 1 comment
Closed

Update dom.isFocusable function (PR#1211) #1208

jeeyyy opened this issue Oct 28, 2018 · 1 comment
Assignees
@jeeyyy
Labels
fix Bug fixes rules Issue or false result from an axe-core rule

Comments

@jeeyyy
Copy link
Contributor

jeeyyy commented Oct 28, 2018

  • remove the usage of isVisible.
  • write a new function isCssVisible and swap usage of isVisible.

isCssVisible should

  • ignore aria-hidden.
  • ignore off-screen elements.
  • ensure parent visibility inheritance.
@jeeyyy jeeyyy added the fix Bug fixes label Oct 28, 2018
@jeeyyy jeeyyy self-assigned this Oct 28, 2018
jeeyyy added a commit that referenced this issue Oct 28, 2018
@jeeyyy
fix: revert changes to isFocusable. To be tackled by issue #1208
212d0da
This was referenced Oct 28, 2018
Merged
Merged
@WilcoFiers WilcoFiers added the rules Issue or false result from an axe-core rule label Oct 31, 2018
@jeeyyy jeeyyy changed the title Update dom.isFocusable function Update dom.isFocusable function (PR#1211) Nov 2, 2018
@jeeyyy
Copy link
Contributor Author

jeeyyy commented Nov 8, 2018

PR merged. Closing issue.

@jeeyyy jeeyyy closed this as completed Nov 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeeyyy jeeyyy

Labels
fix Bug fixes rules Issue or false result from an axe-core rule
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@WilcoFiers @jeeyyy