False negative: 'image-alt' rule does not fail for alt=" " #1174
Assignees
Labels
Comments
|
This should probably be a separate check so that we can report the issue accurately, and so that its easy to turn off. |
marcysutton
pushed a commit
that referenced
this issue
Nov 27, 2018
The image-alt rule now checks for space characters, and fails if they are present. Empty alt attributes are still fine, and text content is still fine. This fixes cases where ATs do not skip decorative images because of the space characters in the alt attribute. Closes #1174
4 tasks
marcysutton
pushed a commit
that referenced
this issue
Nov 27, 2018
The image-alt rule now checks for space characters, and fails if they are present. Empty alt attributes are still fine, and text content is still fine. This fixes cases where ATs do not skip decorative images because of the space characters in the alt attribute. Closes #1174
WilcoFiers
pushed a commit
that referenced
this issue
Dec 7, 2018
* feat(image-alt): require alt text or empty strings The image-alt rule now checks for space characters, and fails if they are present. Empty alt attributes are still fine, and text content is still fine. This fixes cases where ATs do not skip decorative images because of the space characters in the alt attribute. Closes #1174 * chore: include updated build files (there are no actual changes) * chore: rename to alt-space-value, focus on images * fix: PR feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Demo:
<img id="test" src="" alt=" ">AT Tests:
The text was updated successfully, but these errors were encountered: