False positive: color-contrast fails on <i> tags used as icons #1068
Labels
color contrast
Color contrast issues
fix
Bug fixes
rules
Issue or false result from an axe-core rule
support
Comments
|
Fair point. I've been thinking of marking very small "texts" like this for review instead. I think that would be the proper solution. |
This was referenced Aug 23, 2018
WilcoFiers
added a commit
that referenced
this issue
Aug 23, 2018
This fix ensures that font icons and other single character elements are put into needs review for the color-contrast rule. Closes #1068 ## Reviewer checks **Required fields, to be filled out by PR reviewer(s)** - [x] Follows the commit message policy, appropriate for next version - [x] Has documentation updated, a DU ticket, or requires no documentation change - [x] Includes new tests, or was unnecessary - [x] Code is reviewed for security by: @dylanb
|
@WilcoFiers Thoughts on revisiting the original solution for this one, or making it configurable? There are plenty of cases where a single character element needs to have appropriate contrast. Even in the OP's image, there are single digit numbers on the right column which need to be accessible. Maybe this could be addressed via some sort of configuration for a text content blacklist/regex so that people can only ignore certain characters? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Color-contrastfails on<i>tags used as icons. The failure is due to the unicode () rendered in the DOMThe text was updated successfully, but these errors were encountered: