fix(aria-allowed-children,aria-allowed-parent): allow group role in l…

…istbox (#3195) * fix(aria-allowed-children,aria-allowed-parent): allow group role in listbox * fix tests
dequelabs · Oct 18, 2021 · d742b29 · d742b29
1 parent aa9c145
commit d742b29
Show file tree

Hide file tree

Showing 6 changed files with 27 additions and 5 deletions.
diff --git a/lib/standards/aria-roles.js b/lib/standards/aria-roles.js
@@ -279,7 +279,7 @@ const ariaRoles = {
   },
   listbox: {
     type: 'composite',
-    requiredOwned: ['option'],
+    requiredOwned: ['group', 'option'],
     allowedAttrs: [
       'aria-multiselectable',
       'aria-readonly',
@@ -408,7 +408,7 @@ const ariaRoles = {
   },
   option: {
     type: 'widget',
-    requiredContext: ['listbox'],
+    requiredContext: ['group', 'listbox'],
     // Note: since the option role has an implicit
     // aria-selected value it is not required to be added by
     // the user

diff --git a/test/checks/aria/required-children.js b/test/checks/aria/required-children.js
@@ -323,7 +323,7 @@ describe('aria-required-children', function() {
 
   it('should fail when role does not allow group', function() {
     var params = checkSetup(
-      '<div role="listbox" id="target"><ul role="group"><li role="option">Option</li></ul></div>'
+      '<div role="table" id="target"><ul role="group"><li role="row">Option</li></ul></div>'
     );
     assert.isFalse(
       axe.testUtils

diff --git a/test/integration/rules/aria-required-children/aria-required-children.html b/test/integration/rules/aria-required-children/aria-required-children.html
@@ -55,3 +55,16 @@
     <li role="menuitem" id="ignore14">>Trash</li>
   </ul>
 </div>
+
+<div role="suggestion" id="pass8">
+  <span role="deletion">option</span>
+  <span role="insertion">option</span>
+</div>
+
+<div role="suggestion" id="fail8"></div>
+
+<div role="listbox" id="pass9">
+  <div role="group">
+    <div role="option">option</div>
+  </div>
+</div>
diff --git a/test/integration/rules/aria-required-children/aria-required-children.json b/test/integration/rules/aria-required-children/aria-required-children.json
@@ -17,7 +17,9 @@
     ["#pass4"],
     ["#pass5"],
     ["#pass6"],
-    ["#pass7"]
+    ["#pass7"],
+    ["#pass8"],
+    ["#pass9"]
   ],
   "incomplete": [
     ["#incomplete1"],

diff --git a/test/integration/rules/aria-required-parent/aria-required-parent.html b/test/integration/rules/aria-required-parent/aria-required-parent.html
@@ -58,3 +58,9 @@
     </div>
   </div>
 </div>
+
+<div role="listbox">
+  <div role="group">
+    <div role="option" id="pass13">option</div>
+  </div>
+</div>
diff --git a/test/integration/rules/aria-required-parent/aria-required-parent.json b/test/integration/rules/aria-required-parent/aria-required-parent.json
@@ -22,6 +22,7 @@
     ["#pass9"],
     ["#pass10"],
     ["#pass11"],
-    ["#pass12"]
+    ["#pass12"],
+    ["#pass13"]
   ]
 }