fix(aria-allowed-role): allow role=presentation on hr (#2300)

* fix(aria-allowed-role): allow role=presentation on hr * add test
dequelabs · Jun 18, 2020 · b524ea9 · b524ea9
1 parent 9857978
commit b524ea9
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 1 deletion.
diff --git a/lib/commons/aria/lookup-table.js b/lib/commons/aria/lookup-table.js
@@ -1429,6 +1429,7 @@ lookupTable.role = {
 					'h5',
 					'h6',
 					'header',
+					'hr',
 					'iframe',
 					'li',
 					'ol',
@@ -1515,6 +1516,7 @@ lookupTable.role = {
 					'h5',
 					'h6',
 					'header',
+					'hr',
 					'iframe',
 					'li',
 					'ol',

diff --git a/test/integration/rules/aria-allowed-role/aria-allowed-role.html b/test/integration/rules/aria-allowed-role/aria-allowed-role.html
@@ -167,6 +167,8 @@ <h1 id="pass-h1-valid-role" role="none"></h1>
 <ul>
 	<li id="pass-dpub-7" role="doc-endnote">ok</li>
 </ul>
+<hr id="hr-presentation" role="presentation" />
+<hr id="hr-none" role="none" />
 
 <dd id="fail-dd-no-role" role="link"></dd>
 <dt id="fail-dt-no-role" role="banner"></dt>

diff --git a/test/integration/rules/aria-allowed-role/aria-allowed-role.json b/test/integration/rules/aria-allowed-role/aria-allowed-role.json
@@ -64,7 +64,9 @@
 		["#pass-dpub-4"],
 		["#pass-dpub-5"],
 		["#pass-dpub-6"],
-		["#pass-dpub-7"]
+		["#pass-dpub-7"],
+		["#hr-presentation"],
+		["#hr-none"]
 	],
 	"violations": [
 		["#fail-dd-no-role"],