fix: Properly output error stack

dequelabs · Jun 22, 2017 · 56f1867 · 56f1867
1 parent 57ec9d7
commit 56f1867
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/lib/core/base/audit.js b/lib/core/base/audit.js
@@ -165,7 +165,7 @@ Audit.prototype.run = function (context, options, resolve, reject) {
 							result: axe.constants.CANTTELL,
 							description: 'An error occured while running this rule',
 							message: err.message,
-							help: err.stack || err.message,
+							stack: err.stack,
 							error: err
 						});
 						res(errResult);

diff --git a/test/core/base/audit.js b/test/core/base/audit.js
@@ -496,6 +496,7 @@ describe('Audit', function () {
 		});
 
 		it('catches errors and passes them as a cantTell result', function (done) {
+			var err = new Error('Launch the super sheep!');
 			a.addRule({
 				id: 'throw1',
 				selector: '*',
@@ -506,7 +507,7 @@ describe('Audit', function () {
 			a.addCheck({
 				id: 'throw1-check1',
 				evaluate: function () {
-					throw new Error('Launch the super sheep!');
+					throw err;
 				}
 			});
 
@@ -518,7 +519,9 @@ describe('Audit', function () {
 			}, function (results) {
 				assert.lengthOf(results,1);
 				assert.equal(results[0].result, 'cantTell');
-				assert.equal(results[0].error.message, 'Launch the super sheep!');
+				assert.equal(results[0].message, err.message);
+				assert.equal(results[0].stack, err.stack);
+				assert.equal(results[0].error, err);
 				done();
 			}, isNotCalled);
 		});