fix(page-no-duplicate-main): do not fail for duplicate hidden elements (

#2000)
dequelabs · Jan 29, 2020 · 414dfb1 · 414dfb1
1 parent 6429e60
commit 414dfb1
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/lib/checks/keyboard/page-no-duplicate.js b/lib/checks/keyboard/page-no-duplicate.js
@@ -15,7 +15,7 @@ axe._cache.set(key, true);
 let elms = axe.utils.querySelectorAllFilter(
 	axe._tree[0],
 	options.selector,
-	elm => elm !== virtualNode
+	elm => elm !== virtualNode && axe.commons.dom.isVisible(elm.actualNode)
 );
 
 // Filter elements that, within certain contexts, don't map their role.

diff --git a/test/checks/keyboard/page-no-duplicate.js b/test/checks/keyboard/page-no-duplicate.js
@@ -50,6 +50,15 @@ describe('page-no-duplicate', function() {
 			assert.isTrue(check.evaluate.apply(checkContext, params));
 		});
 
+		it('should return true if there is more than one element matching the selector but only one is visible', function() {
+			var options = { selector: 'main' };
+			var params = checkSetup(
+				'<div><main id="target"></main><main id="dup" style="display:none;"></main></div>',
+				options
+			);
+			assert.isTrue(check.evaluate.apply(checkContext, params));
+		});
+
 		(shadowSupported ? it : xit)(
 			'should return false if there is a second matching element inside the shadow dom',
 			function() {