fix(is-visible): do not error if window.Node does not exist (#3168)

* fix(is-visible): do not error if window.Node does not exist * circle * Update test/test-virtual-rules.js Co-authored-by: Wilco Fiers <[email protected]> Co-authored-by: Wilco Fiers <[email protected]>
dequelabs · Sep 28, 2021 · 4046087 · 4046087
1 parent ad4b165
commit 4046087
Show file tree

Hide file tree

Showing 4 changed files with 41 additions and 1 deletion.
diff --git a/.circleci/config.yml b/.circleci/config.yml
@@ -129,6 +129,16 @@ jobs:
       - run: npm run build
       - run: npm run test:locales
 
+  # Test virtual rules
+  test_virtual_rules:
+    <<: *defaults
+    <<: *unix_box
+    steps:
+      - checkout
+      - <<: *restore_dependency_cache_unix
+      - run: npm run build
+      - run: npm run test:virtual-rules
+
   # Run the test suite for nightly builds.
   test_nightly:
     <<: *defaults
@@ -262,6 +272,9 @@ workflows:
       - test_locales:
           requires:
             - test_unix
+      - test_virtual_rules:
+          requires:
+            - test_unix
       - build_api_docs:
           requires:
             - test_unix
@@ -279,6 +292,7 @@ workflows:
             - test_win
             - test_examples
             - test_locales
+            - test_virtual_rules
             - build_api_docs
             - test_rule_help_version
             - test_node
@@ -293,6 +307,7 @@ workflows:
             - test_unix
             - test_examples
             - test_locales
+            - test_virtual_rules
             - build_api_docs
           filters:
             branches:
@@ -304,6 +319,7 @@ workflows:
             - test_unix
             - test_examples
             - test_locales
+            - test_virtual_rules
             - build_api_docs
             - test_rule_help_version
             - test_node

diff --git a/lib/commons/dom/is-visible.js b/lib/commons/dom/is-visible.js
@@ -117,7 +117,7 @@ function isVisible(el, screenReader, recursed) {
   el = vNode ? vNode.actualNode : el;
 
   const cacheName = '_isVisible' + (screenReader ? 'ScreenReader' : '');
-  const { DOCUMENT_NODE, DOCUMENT_FRAGMENT_NODE } = window.Node;
+  const { DOCUMENT_NODE, DOCUMENT_FRAGMENT_NODE } = window.Node ?? {};
   const nodeType = vNode ? vNode.props.nodeType : el.nodeType;
   const nodeName = vNode ? vNode.props.nodeName : el.nodeName.toLowerCase();
 

diff --git a/package.json b/package.json
@@ -94,6 +94,7 @@
     "test:act": "karma start test/act-mapping/karma.config.js",
     "test:act:debug": "npm run test:act -- --no-single-run --browsers=Chrome",
     "test:locales": "mocha test/test-locales.js",
+    "test:virtual-rules": "mocha test/test-virtual-rules.js",
     "test:rule-help-version": "mocha test/test-rule-help-version.js",
     "test:node": "mocha test/node/*.js",
     "version": "echo \"use 'npm run release' to bump axe-core version\" && exit 1",

diff --git a/test/test-virtual-rules.js b/test/test-virtual-rules.js
@@ -0,0 +1,23 @@
+var path = require('path');
+var assert = require('chai').assert;
+var glob = require('glob');
+var axe = require('../axe');
+
+var files = glob.sync(path.join(__dirname, 'integration/virtual-rules/*.js'));
+
+before(function() {
+  global.axe = axe;
+  global.assert = assert;
+});
+
+after(function() {
+  delete global.axe;
+  delete global.assert;
+});
+
+describe('virtual-rule node tests', function() {
+  files.forEach(function(file) {
+    // load the test file and run with global axe and assert now defined
+    require(file);
+  });
+});