Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: enable manual run of patch release #321

Merged
merged 9 commits into from
Sep 7, 2023
Merged

ci: enable manual run of patch release #321

merged 9 commits into from
Sep 7, 2023

Conversation

AdnoC
Copy link
Contributor

@AdnoC AdnoC commented Aug 24, 2023

@AdnoC AdnoC marked this pull request as ready for review August 24, 2023 17:04
@AdnoC AdnoC requested a review from a team as a code owner August 24, 2023 17:04

sed -i -e "s/ VERSION\\s*=\\s*\"$oldVersion\"/ VERSION = \"$newVersion\"/" version.rb

npx conventional-changelog-cli@"$CHANGELOG_VERSION" -p angular -i CHANGELOG.md -s
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the reason for skipping changelog generation in standard-version but then doing it here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was a point where the version of standart-version and conventional-changelog-cli was set via environmental variable. In that case it was necessary to separate the steps. This has been changed.

- name: Create release
uses: dequelabs/axe-api-team-public/.github/actions/auto-patch-release-v1@main
with:
token: ${{ secrets.GITHUB_TOKEN }}
skip_checks: ${{ steps.skip-checks.outputs.value }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you not do the expression here rather than having a separate step to do it?

Suggested change
skip_checks: ${{ steps.skip-checks.outputs.value }}
skip_checks: ${{ github.event_name != schedule }}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need the string true or false, so we use the output

@AdnoC AdnoC merged commit 0345aa9 into develop Sep 7, 2023
2 checks passed
@AdnoC AdnoC deleted the ci-patch-manual branch September 7, 2023 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants