Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Chore] Emotion theme 세팅 #252

Merged
merged 5 commits into from
Sep 10, 2023
Merged

[Chore] Emotion theme 세팅 #252

merged 5 commits into from
Sep 10, 2023

Conversation

kimyouknow
Copy link
Member

작업 내용

  • typo theme 추가
  • theme provider 세팅

스크린샷

사용 방법

레퍼런스

@kimyouknow kimyouknow self-assigned this Sep 9, 2023
@vercel
Copy link

vercel bot commented Sep 9, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
www-depromeet-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 10, 2023 10:38am

@github-actions github-actions bot added the style change style or request it label Sep 9, 2023
@kimyouknow
Copy link
Member Author

ci 실패 된 건 #251 이거 머지되고 해결할게요~

zzi-0
zzi-0 reviewed Sep 10, 2023
View reviewed changes
src/styles/typo.ts Outdated
pretendard: {
subTitle1: css`
/* Pretendard/Subtitle Bold */
font-size: 32px;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rem으로 바꾸는건 어떨까욥?!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

좋아요~

@github-actions
Copy link

github-actions bot commented Sep 10, 2023 •
edited
Loading

Bundle Sizes

Compared against d4bc7f9

Route Size (gzipped) Diff
/ 72.18 KB -10.08 KB
/404 71.89 KB -4.91 KB
/_app 109.08 KB -21.84 KB
/about 72.2 KB -12.73 KB
/project 72.2 KB -22.66 KB
/recruit 72.2 KB -13.04 KB
/contact no change removed
/project/[projectTitle] no change removed
/recruit/[position] no change removed
Dynamic import Size (gzipped) Diff
../components/project-detail/OtherProjectSection.tsx -> ../project/ProjectItem/ProjectItem no change removed

@kimyouknow kimyouknow merged commit 93142ee into develop Sep 10, 2023
@kimyouknow kimyouknow deleted the feat/theme-setting branch September 10, 2023 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zzi-0 zzi-0 zzi-0 approved these changes

@sumi-0011 sumi-0011 Awaiting requested review from sumi-0011

Assignees

@kimyouknow kimyouknow

Labels
style change style or request it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kimyouknow @zzi-0