✨ checkbox component #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doyoonear
reviewed
Nov 21, 2022
src/components/common/CheckBox.tsx
Outdated
| } | ||
|
|
||
| const CheckBox = ({ checked, disabled, label, onChange, ...props }: Props) => { | ||
| const [isChecked, setIsChecked] = useState(false); |
There was a problem hiding this comment.
checked 값을 이미 props로 받고있는데 체크박스 컴포넌트 내부에서 따로 isChecked 상태를 관리하는 이유가 뭔가요?
There was a problem hiding this comment.
데이터를 미리 fetch 할 수 있는 경우를 생각했는데,,,,, 이 컴포넌트에서는 필요없겠네용 수정하겠습니다
hwangyena
force-pushed
the
feature/checkbox
branch
from
e05a76c to
de77bcb
Compare
hwangyena
force-pushed
the
feature/checkbox
branch
from
de77bcb to
314bc8e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's Changed?
Screenshots
Related to any issues?
Dependency Changes
Test Code