Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to [email protected] #9

Merged
merged 5 commits into from
Nov 6, 2022
Merged

Upgrade to [email protected] #9

merged 5 commits into from
Nov 6, 2022

Conversation

hyesungoh
Copy link
Member

@hyesungoh hyesungoh commented Oct 26, 2022

๐Ÿค” ํ•ด๊ฒฐํ•˜๋ ค๋Š” ๋ฌธ์ œ๊ฐ€ ๋ฌด์—‡์ธ๊ฐ€์š”?

  • Next.js 13.0.0 ๋งˆ์ด๊ทธ๋ ˆ์ด์…˜

๐ŸŽ‰ ์–ด๋–ป๊ฒŒ ํ•ด๊ฒฐํ–ˆ๋‚˜์š”?

  • next, eslint-config-next์˜ ๋ฒ„์ „์„ 13.0.0์œผ๋กœ ์˜ฌ๋ ธ์–ด์š”

appDir ๋น„ํ™œ์„ฑํ™”

ํ˜„์žฌ appDir์„ ํ™œ์„ฑํ™”ํ•˜๋ฉด (8c78063) emotion๊ณผ ์ถฉ๋Œ์ด ์ผ์–ด๋‚˜๋Š” ๊ฒƒ ๊ฐ™์Šต๋‹ˆ๋‹ค.

แ„‰แ…ณแ„แ…ณแ„…แ…ตแ†ซแ„‰แ…ฃแ†บ 2022-10-27 แ„‹แ…ฉแ„Œแ…ฅแ†ซ 12 03 07

๋‹จ์ ์œผ๋กœ next.config.js์˜ emotion ์˜ต์…˜์„ ๋น„ํ™œ์„ฑํ™”ํ•˜๋ฉด ์ •์ƒ์ ์œผ๋กœ ์‹คํ–‰๋˜๋Š” ๊ฒƒ์„ ํ™•์ธํ–ˆ์–ด์š”.

์•„์ง ์ด๋ฅด๋‹ค๊ณ  ์ƒ๊ฐ๋˜์–ด ๋น„ํ™œ์„ฑํ™” ํ•ด๋‘์—ˆ์Šต๋‹ˆ๋‹ค.


tsconfig

แ„‰แ…ณแ„แ…ณแ„…แ…ตแ†ซแ„‰แ…ฃแ†บ 2022-10-27 แ„‹แ…ฉแ„Œแ…ฅแ†ซ 12 22 45

์‹คํ–‰ ์‹œ tsconfig๋ฅผ ์—…๋ฐ์ดํŠธ ํ•ด์ฃผ๋”๋ผ๊ตฌ์š”. fc6bcae

Strict-mode is set to false by default

๋ผ๊ณ ๋Š” ํ•˜๋Š”๋ฐ, strict ์˜ต์…˜์ด false๊ฐ€ ๋˜์ง„ ์•Š๋„ค์š”..?


dev:turbo ์Šคํฌ๋ฆฝํŠธ ์„ค์ •

yarn dev:turbo

์œ„ ๋ช…๋ น์–ด๋ฅผ ์ด์šฉํ•ด dev ์„œ๋ฒ„๋ฅผ ํ‚ฌ ์ˆ˜ ์žˆ๋„๋ก ์„ค์ •ํ•ด ๋‘์—ˆ์–ด์š”.

turbopack์ด ์•„์ง ๋นŒ๋“œ๋Š” ์ง€์›ํ•˜์ง€ ์•Š๋Š”๋‹ค๊ณ  ํ•ด์š”.

๊ทผ๋ฐ ๋ฌด์Šจ ์šฉ๊ฑด์—์„ ์ง€ (์•„์ง๋„ ๋ชจ๋ฆ„) ์›น์— ์ ‘์† ์‹œ ๋‹ค์Œ ์—๋Ÿฌ๋ฅผ ๋ฑ‰๋”๋ผ๊ตฌ์š”.

error - [resolve]
  [next]/dev/client.ts
    Error resolving commonjs request
    unable to resolve module "typescript"

    Error resolving type request
    unable to resolve module "node"

  [next]/dev/hmr-client.ts
    Error resolving commonjs request
    unable to resolve module "typescript"

    Error resolving type request
    unable to resolve module "node"
...

์ผ๋‹จ์€ ๊ทธ๋ƒฅ ๋ฐ๋ธŒ ๋ชจ๋“œ๋กœ ๊ฐœ๋ฐœ์„ ํ•ด์•ผํ•  ๊ฒƒ ๊ฐ™์•„์š” ,,

๐Ÿ“š Attachment (Option)

turbopack์ด ๊ถ๊ธˆํ•ด ์กฐ๊ธˆ ์ฝ์–ด๋ดค๋Š”๋ฐ ๋ˆˆ์— ๋„๋Š” ์‚ฌํ•ญ์„ ๊ณต์œ  ๋“œ๋ ค์š”

closes #6

@github-actions
Copy link

github-actions bot commented Oct 26, 2022

Bundle Sizes

Compared against cffdd6d

Route Size (gzipped) Diff
/ 71.46 KB -6.29 KB
/_app 114.41 KB -7.33 KB
/_error 71.39 KB -6.29 KB

Dynamic import: None found.

@codecov-commenter
Copy link

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage ๐Ÿ‘

Coverage data is based on head (bb58dee) compared to base (cee2353).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##              main        #9   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           21        21           
  Branches         6         6           
=========================================
  Hits            21        21           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

โ˜” View full report at Codecov.
๐Ÿ“ข Do you have feedback about the report comment? Let us know in this issue.

@kooku0
Copy link
Collaborator

kooku0 commented Oct 29, 2022

yarn dev:turbo

turbo ๊ฐ€ default๊ฐ€ ์•„๋‹ˆ๋ผ ์˜ต์…˜์œผ๋กœ ์ค˜์•ผํ•˜๊ตฐ์š”.

๋ญ”๊ฐ€ turbo๊ฐ€ ์•„์ง ์™„์„ฑ์ด ๋˜์ง€ ์•Š์•˜์ง€๋งŒ ์ปจํผ๋Ÿฐ์Šค ์ผ์ •์— ๋งž์ถฐ ๊ณต๊ฐœํ•˜๊ธฐ ํ•ด์•ผํ•˜๊ธฐ์— unstable ๋ฒ„์ „์„ ๋‚ด๋†“์€๊ฒƒ ๊ฐ™๋„ค์š”.
์œ ์ €๊ฐ€ ์ด์Šˆ๋ผ์ด์ง• ํ•ด์ค˜์„œ ๊ณ ์ณ์ค˜๋„ ๋•กํ..

@hyesungoh
Copy link
Member Author

appDir + emotion์€ ๋ฆฌ์•กํŠธ ์„œ๋ฒ„ ์ปดํฌ๋„ŒํŠธ ๋•Œ๋ฌธ์ธ ๊ฒƒ์œผ๋กœ ๋ณด์ด๋„ค์š” ...!

vercel/next.js#41994

์ž์„ธํ•œ ์‚ฌํ•ญ์€ ์œ„ ์ด์Šˆ์—์„œ ํ™•์ธํ•˜์‹ค ์ˆ˜ ์žˆ์„ ๊ฑฐ ๊ฐ™์•„์šฉ

@kooku0
Copy link
Collaborator

kooku0 commented Nov 4, 2022

๋นŒ๋“œ ํŒŒ์ผํฌ๊ธฐ๊ฐ€ ๋งŽ์ด ์ค„์–ด๋“ค์—ˆ๋„ค์š” ์˜ค
๋‚ด๋ถ€์ ์œผ๋กœ ์ตœ์ ํ™”๊ฐ™์€๊ฒŒ ๋œ๊ฑด๊ฐ€....

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Nov 6, 2022

Deploying with ย Cloudflare Pages ย Cloudflare Pages

Latest commit: 9e2eab1
Status:ย โœ…ย  Deploy successful!
Preview URL: https://57429d95.12-team3-web.pages.dev
Branch Preview URL: https://issue-6.12-team3-web.pages.dev

View logs

@hyesungoh hyesungoh changed the title Upgrade to [email protected] Upgrade to [email protected] Nov 6, 2022
@hyesungoh hyesungoh merged commit f34be5b into main Nov 6, 2022
@hyesungoh hyesungoh deleted the issue/6 branch November 6, 2022 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Next.js 13 migration
3 participants