-
Notifications
You must be signed in to change notification settings - Fork 1
Repair patch #2
base: main
Are you sure you want to change the base?
Repair patch #2
Conversation
This patch did not install. ``` Gathering patches for root package. Gathering patches for dependencies. This might take a minute. Found 1 patches for symfony/dependency-injection. - Installing symfony/dependency-injection (v6.1.12): Extracting archive Executing async command (CWD): '/usr/bin/unzip' -qq '/Users/antonevers/web/AntonEvers/monorepo-builder/vendor/composer/tmp-994403dcf948f97b159c6e40ba3dad06' -d '/Users/antonevers/web/AntonEvers/monorepo-builder/vendor/composer/788c53c7' Executing async command (CWD): rm -rf '/Users/antonevers/web/AntonEvers/monorepo-builder/vendor/composer/788c53c7' > post-package-install: cweagans\Composer\Patches->postInstall - Applying patches for symfony/dependency-injection https://raw.githubusercontent.com/symplify/vendor-patch-files/main/patches/generic-php-config-loader.patch (0) Downloading https://raw.githubusercontent.com/symplify/vendor-patch-files/main/patches/generic-php-config-loader.patch patch '-p1' --no-backup-if-mismatch -d '/Users/antonevers/web/AntonEvers/monorepo-builder/vendor/symfony/dependency-injection' < '/var/folders/p6/y1jmbsqx1kv6lhwntxczrv600000gn/T/63f8a0115e465.patch' Executing command (CWD): patch '-p1' --no-backup-if-mismatch -d '/Users/antonevers/web/AntonEvers/monorepo-builder/vendor/symfony/dependency-injection' < '/var/folders/p6/y1jmbsqx1kv6lhwntxczrv600000gn/T/63f8a0115e465.patch' patching file 'Loader/PhpFileLoader.php' Patch creates file that already exists! Assume -R? [y] ``` After this change, it does install. I have also removed the whitespace changes at the end of the patch that were not adding anything functional.
@TomasVotruba I suspect that this has something to do with running the patch command on a mac:
I suspect that this patch format is more compatible with mac and linux alike. |
Hi Anton, thanks for the PR. Where exactly this patch did not install? Changing paths can easily break it. |
I am running it on a mac. I suppose the same thing is going on with the patches in the rector repo. |
We'll need a test case in CI for Mac then to make sure this passes and does not break on other OS. |
This reverts commit 35fdb1c.
I understand. If you like I can test running this patch on a linux machine. |
This should fail and later pass with deprecated-packages/vendor-patch-files#2
@AntonEvers This commit able to resolve your problem |
This patch did not install.
After this change, it does install.
I have also removed the whitespace changes at the end of the patch that were not adding anything functional.