This repository has been archived by the owner on Dec 3, 2023. It is now read-only.
[PHPStan] Set compatible with upcoming PHPStan 1.6.x with set NodeConnectingVisitor tags #4029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All checks have passed 🎉 @TomasVotruba @ondrejmirtes I think it is ready. |
|
I wonder, can we get rid of these extra tags? We can upgrade the rules not to need those. |
|
I am not sure, for example, lookup |
|
The goal of this PR is to make compatible first very early, and in the future, we can update to use specific visitor when possible. |
|
I see 👍 |
This was referenced Apr 15, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on @ondrejmirtes request at rectorphp/rector-src#2014 (review) , this PR update to set compatible with upcoming PHPStan 1.6.x with update require of phpstan to ^1.5.6 and update
conditionalTagsofNodeConnectingVisitorfor symplify as well.