-
-
Notifications
You must be signed in to change notification settings - Fork 187
[RuleDocGenerator] Link rule class to source #2956
[RuleDocGenerator] Link rule class to source #2956
Conversation
Looks good. How does it work on split package? |
How do you mean? How it looks on Rector's side? |
In split package of Symplify monorepo, like: |
How to test? |
It looks it's tested correctly on split package: https://github.com/symplify/symplify/pull/2956/checks?check_run_id=1903101376 👍 Just tests need an update to differ between monorepo run and split run. |
Btw, were using naming convention for pull-request, like Could you use this convention in PRs so these pull-request will be assigned to right packages? |
058952e
to
50c5497
Compare
@TomasVotruba It's ready now 🎉 ✅ |
Looks good, thank you 👍 |
Fixes rectorphp/rector#5476
Is this the right approach? If so, I can fix the PHPStan errors.