Skip to content
This repository has been archived by the owner on Dec 3, 2023. It is now read-only.

[RuleDocGenerator] Link rule class to source #2956

Merged
merged 4 commits into from
Feb 15, 2021

Conversation

ruudk
Copy link
Contributor

@ruudk ruudk commented Feb 15, 2021

Fixes rectorphp/rector#5476

Is this the right approach? If so, I can fix the PHPStan errors.

@TomasVotruba
Copy link
Member

Looks good. How does it work on split package?

@ruudk
Copy link
Contributor Author

ruudk commented Feb 15, 2021

How do you mean? How it looks on Rector's side?

@TomasVotruba
Copy link
Member

TomasVotruba commented Feb 15, 2021

@ruudk
Copy link
Contributor Author

ruudk commented Feb 15, 2021

How to test?

@TomasVotruba
Copy link
Member

TomasVotruba commented Feb 15, 2021

It looks it's tested correctly on split package: https://github.com/symplify/symplify/pull/2956/checks?check_run_id=1903101376 👍

Just tests need an update to differ between monorepo run and split run.
Check tests/bootstrap.php - there is a constant that is present only monorepo tests: https://github.com/symplify/symplify/blob/1353bd6ae212d520f7b7a43902e83edae8c91bcb/tests/bootstrap.php#L21

@TomasVotruba
Copy link
Member

Btw, were using naming convention for pull-request, like [PackageName] The title.
That way we can automatically generate per-package changelog once a week, without much effort.

Could you use this convention in PRs so these pull-request will be assigned to right packages?
Thank you

@ruudk ruudk changed the title Make rule class link to rule source [RuleDocGenerator] Make rule class link to rule source Feb 15, 2021
@ruudk ruudk changed the title [RuleDocGenerator] Make rule class link to rule source [RuleDocGenerator] Link rule class to source Feb 15, 2021
@ruudk
Copy link
Contributor Author

ruudk commented Feb 15, 2021

@TomasVotruba It's ready now 🎉 ✅

@ruudk ruudk requested a review from TomasVotruba February 15, 2021 18:11
@TomasVotruba
Copy link
Member

Looks good, thank you 👍

@TomasVotruba TomasVotruba enabled auto-merge (squash) February 15, 2021 19:32
@TomasVotruba TomasVotruba merged commit 2916bb2 into deprecated-packages:master Feb 15, 2021
@ruudk ruudk deleted the rule-doc-source branch February 15, 2021 19:35
@deprecated-packages deprecated-packages locked as resolved and limited conversation to collaborators Feb 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Docs > rector_rules_overview.md > Add link to rector source
2 participants