-
-
Notifications
You must be signed in to change notification settings - Fork 187
Full support for PHP 8.0 #2111
Full support for PHP 8.0 #2111
Conversation
Hi, thanks for contribution. Why the close? |
There are still some failed test cases that need to be confirmed, Such as: |
Could you add PHP 8.0 to the test build matrix so we can see those cases? It would be easier to address them then |
https://github.com/symplify/symplify/pull/2111/checks?check_run_id=1061929604 |
only this failed test case cannot find any commits/issues/PRs, but i think it was caused by squizlabs/php_codesniffer, This PR can be merged if you don't have to wait for those fixes. Test case
|
PHP8 have some reflection deprecations, check this article: https://php.watch/versions/8.0/deprecated-reflectionparameter-methods Fow now rector fails to run at least because of: Deprecated: Method ReflectionParameter::isArray() is deprecated in /tmp/test/vendor/symplify/autowire-array-parameter/src/DependencyInjection/CompilerPass/AutowireArrayParameterCompilerPass.php on line 148` |
I just created a new PR #2402 , this issue will be resolved. |
I've just re-run CI to see how this PR is doing. Few packages changes have been merged to I'll make sure this will get attention and quick responses, so we can merge it 👍 |
I've just "rebased" branch on current |
Wow, CI is green ✔️ 🎉 Great job! |
I'll merge it as it is, so we have PHP 8.0 checks for new code too and test it on Next PRs with further tuning are welcomed 👍 |
Requirements:
nette/robot-loader new release
squizlabs/php_codesniffer
: PHP 8.0 | "undo" namespaced names as single token squizlabs/PHP_CodeSniffer#3063squizlabs/php_codesniffer
: ^3.5.7 releaseSupport Composer 2 natively Jean85/pretty-package-versions#14
friendsofphp/php-cs-fixer
: PHP 8.0 support PHP-CS-Fixer/PHP-CS-Fixer#4702, [WIP] Transform PHP 8 qualified names PHP-CS-Fixer/PHP-CS-Fixer#5114, composer: allow PHP 8 PHP-CS-Fixer/PHP-CS-Fixer#5134PHP 8.0 migration rule set
Remove
doctrine/doctrine-cache-bundle
: Deprecation of DoctrineCacheBundle doctrine/DoctrineCacheBundle#156PHP8 Support doctrine/orm#8303
Revert extra build steps