-
-
Notifications
You must be signed in to change notification settings - Fork 189
[MonorepoBuilder] Incorrect version in release command #2972
Comments
Hi, we'll need a failing test case for this. |
I didn't find any integration tests. And the unit tests of the version will cover this class: https://github.com/phar-io/version/blob/master/src/Version.php The problem is that this object is used directly as tags: Maybe the version should be passed as a string? And parse only in those places where we need to get version info. |
It might require a new test, it's ok |
So it looks like this was a change in phar-io that caused this rather than something in symplify Specifically the change to this line phar-io/version@8cef51d#diff-9cb52248cb807e881c8c2b95169d98aa095f95ee40639b13af3b9f28cc553122L42 |
@addshore Thank you for the investigation! |
Should be easy to fix once there is a new version to use phar-io/version#26 |
There is a new release, so I'll pick this one up now! |
* [MonorepoBuilder] Use original version string for tag Fixes #2972 * propagate phar-io/version version
An incorrect version string is generated during release (missing prefix
v
).This is regression bug: The behavior changes between 7.x and 8.x branches. The error is not related to the operating system or the PHP version.
P.S. I also do not like the prefix
v
, but this is the way it is on the project.Reproduce
monorepo-builder release "v1.0.0"
Expected
Release, named
v1.0.0
Actual
Release, named
1.0.0
The text was updated successfully, but these errors were encountered: