Merge pull request #952 from Symplify/tagging

[ChangelogLinker] [MonorepoBuilder] Fix Travis-related Tagging
deprecated-packages · Jul 10, 2018 · 40e308b · 40e308b
2 parents 7bffd6e + 3f796e6
commit 40e308b
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 20 deletions.
diff --git a/.travis.yml b/.travis.yml
@@ -1,5 +1,10 @@
 language: php
 
+# required for "git tag" presence for MonorepoBuilder split and ChangelogLinker git tags resolver
+# see https://github.com/travis-ci/travis-ci/issues/7422
+git:
+  depth: false
+
 matrix:
   include:
     - php: 7.1

diff --git a/packages/ChangelogLinker/tests/ChangeTree/ChangeFactoryTest.php b/packages/ChangelogLinker/tests/ChangeTree/ChangeFactoryTest.php
@@ -94,11 +94,6 @@ public function testGetMessageWithoutPackage(): void
 
     public function testTagDetection(): void
     {
-        // @see https://docs.travis-ci.com/user/environment-variables/#Default-Environment-Variables
-        if (getenv('TRAVIS')) {
-            $this->markTestSkipped('Travis makes shallow clones, so unable to test commits/tags.');
-        }
-
         $pullRequest = [
             'number' => 10,
             'title' => '[SomePackage] SomeMessage',

diff --git a/packages/ChangelogLinker/tests/ChangelogDumper/WithTagsTest.php b/packages/ChangelogLinker/tests/ChangelogDumper/WithTagsTest.php
@@ -30,11 +30,6 @@ protected function setUp(): void
 
     public function testReportChanges(): void
     {
-        // @see https://docs.travis-ci.com/user/environment-variables/#Default-Environment-Variables
-        if (getenv('TRAVIS')) {
-            $this->markTestSkipped('Travis makes shallow clones, so unable to test commits/tags.');
-        }
-
         $content = $this->changelogDumper->reportChangesWithHeadlines($this->changes, false, false, 'categories');
 
         $this->assertStringEqualsFile(__DIR__ . '/WithTagsSource/expected1.md', $content);
@@ -49,11 +44,6 @@ public function testReportBothWithCategoriesPriority(
         ?string $priority,
         string $expectedOutputFile
     ): void {
-        // @see https://docs.travis-ci.com/user/environment-variables/#Default-Environment-Variables
-        if (getenv('TRAVIS')) {
-            $this->markTestSkipped('Travis makes shallow clones, so unable to test commits/tags.');
-        }
-
         $content = $this->changelogDumper->reportChangesWithHeadlines(
             $this->changes,
             $withCategories,

diff --git a/packages/ChangelogLinker/tests/Git/GitCommitDateTagResolverTest.php b/packages/ChangelogLinker/tests/Git/GitCommitDateTagResolverTest.php
@@ -15,11 +15,6 @@ final class GitCommitDateTagResolverTest extends TestCase
 
     protected function setUp(): void
     {
-        // @see https://docs.travis-ci.com/user/environment-variables/#Default-Environment-Variables
-        if (getenv('TRAVIS')) {
-            $this->markTestSkipped('Travis makes shallow clones, so unable to test commits/tags.');
-        }
-
         $this->gitCommitDateTagResolver = new GitCommitDateTagResolver();
     }