[PHPStanRules] Drop trait requires test, not a good idea

deprecated-packages · Feb 22, 2021 · 127bfe9 · 127bfe9
1 parent c6bd65a
commit 127bfe9
Show file tree

Hide file tree

Showing 6 changed files with 2 additions and 65 deletions.
diff --git a/...tan-rules/tests/Rules/CheckRequiredMethodNamingRule/CheckRequiredMethodNamingRuleTest.php b/...tan-rules/tests/Rules/CheckRequiredMethodNamingRule/CheckRequiredMethodNamingRuleTest.php
@@ -21,21 +21,6 @@ public function testRule(array $filePaths, array $expectedErrorMessagesWithLines
 
     public function provideData(): Iterator
     {
-        $errorMessage = sprintf(CheckRequiredMethodNamingRule::ERROR_MESSAGE, 'autowireRequiredByTrait');
-        yield [
-            [__DIR__ . '/Fixture/ClassUsingRequiredByTrait.php', __DIR__ . '/Fixture/RequiredByTrait.php'],
-            [[$errorMessage, 12]],
-        ];
-
-        $errorMessage = sprintf(CheckRequiredMethodNamingRule::ERROR_MESSAGE, 'autowireRequiredByTraitCorrect');
-        yield [
-            [
-                __DIR__ . '/Fixture/ClassUsingRequiredByTraitCorrect.php',
-                __DIR__ . '/Fixture/RequiredByTraitCorrect.php',
-            ],
-            [[$errorMessage, 12]],
-        ];
-
         yield [[__DIR__ . '/Fixture/SkipWithoutRequired.php'], []];
         yield [[__DIR__ . '/Fixture/SkipCorretName.php'], []];
 

diff --git a/...tan-rules/tests/Rules/CheckRequiredMethodNamingRule/Fixture/ClassUsingRequiredByTrait.php b/...tan-rules/tests/Rules/CheckRequiredMethodNamingRule/Fixture/ClassUsingRequiredByTrait.php
diff --git a/...es/tests/Rules/CheckRequiredMethodNamingRule/Fixture/ClassUsingRequiredByTraitCorrect.php b/...es/tests/Rules/CheckRequiredMethodNamingRule/Fixture/ClassUsingRequiredByTraitCorrect.php
diff --git a/packages/phpstan-rules/tests/Rules/CheckRequiredMethodNamingRule/Fixture/RequiredByTrait.php b/packages/phpstan-rules/tests/Rules/CheckRequiredMethodNamingRule/Fixture/RequiredByTrait.php
diff --git a/...hpstan-rules/tests/Rules/CheckRequiredMethodNamingRule/Fixture/RequiredByTraitCorrect.php b/...hpstan-rules/tests/Rules/CheckRequiredMethodNamingRule/Fixture/RequiredByTraitCorrect.php
diff --git a/phpstan.neon b/phpstan.neon
@@ -474,3 +474,5 @@ parameters:
             message: '#Do not inherit from abstract class, better use composition#'
             paths:
                 - packages/git-wrapper/src
+                - packages/set-config-resolver/src/ConfigResolver.php
+                - packages/set-config-resolver/src/SetAwareConfigResolver.php