fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup!…

… fixup! fixup! fixup! fixup! fixup! fix loading with non root config
deprecated-packages · Jan 10, 2020 · 0e4d360 · 0e4d360
1 parent 91452ef
commit 0e4d360
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 6 deletions.
diff --git a/packages/EasyCodingStandard/compiler/README.md b/packages/EasyCodingStandard/compiler/README.md
@@ -14,3 +14,16 @@ php ../tmp/ecs.phar
 ```
 
 Please note that running the compiler will change the contents of `composer.json` file and `vendor` directory. Revert those changes after running it.
+
+## Notes
+
+This section si needed in `composer.json`, because it was causing autolaoding bugs.
+Box aliases existing Symfony stubs to php, see https://ayesh.me/composer-replace-polyfills.
+
+```json
+{
+    "replace": {
+        "symfony/polyfill-php70": "*"
+    }
+}
+```
diff --git a/packages/EasyCodingStandard/compiler/src/Console/CompileCommand.php b/packages/EasyCodingStandard/compiler/src/Console/CompileCommand.php
@@ -96,12 +96,6 @@ private function fixComposerJson(string $composerJsonFile): void
         $json = $this->replaceDevSymplifyVersionWithLastStableVersion($json);
         $json = $this->fixPhpCodeSnifferAutoloading($json);
 
-        # this was causing autolaoding bugs because of box aliasing existing Symfony stubs to php
-        # see https://ayesh.me/composer-replace-polyfills
-        $json['replace'] = [
-            'symfony/polyfill-php70' => '*',
-        ];
-
         $json = $this->removeDevContent($json);
         $this->cleanupPhpCsFixerBreakingFiles();
 

diff --git a/packages/EasyCodingStandard/composer.json b/packages/EasyCodingStandard/composer.json
@@ -51,6 +51,9 @@
             "Symplify\\EasyCodingStandard\\Tests\\": "tests"
         }
     },
+    "replace": {
+        "symfony/polyfill-php70": "*"
+    },
     "extra": {
         "branch-alias": {
             "dev-master": "7.3-dev"