always success #950
Merged
always success #950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
always success when running unlock
|
I checked, the error is not related with this PR |
antonmedv
requested changes
Jan 11, 2017
| run("rm {{deploy_path}}/.dep/deploy.lock"); | ||
| try { | ||
| run("rm {{deploy_path}}/.dep/deploy.lock");//always success | ||
| } catch (\Exception $e) { |
There was a problem hiding this comment.
It's bad solution to mute all errors, better to use bash or rm options.
There was a problem hiding this comment.
Ok, i change to use -f instead of try catch block
Use -f to avoid error when file is not exist
antonmedv
approved these changes
Jan 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
always success when running unlock
Run
deploy:unlockalways return success instead of exception whendeploy.locknot exist